Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

escape quote characters in interpolations with $ #7486

Merged
merged 1 commit into from Nov 2, 2019
Merged

escape quote characters in interpolations with $ #7486

merged 1 commit into from Nov 2, 2019

Conversation

martijnhoekstra
Copy link
Contributor

dottybot
dottybot reviewed Nov 2, 2019
View reviewed changes
Copy link
Member

@dottybot dottybot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, and thank you for opening this PR! 🎉

All contributors have signed the CLA, thank you! ❤️

Have an awesome day! ☀️

odersky
odersky approved these changes Nov 2, 2019
View reviewed changes
Copy link
Contributor

@odersky odersky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! LGTM

@odersky odersky merged commit 826ac10 into scala:master Nov 2, 2019
@lrytz lrytz mentioned this pull request Mar 8, 2021
Merged
julienrf added a commit to scalacenter/docs.scala-lang that referenced this pull request May 3, 2022
@julienrf
Mark SIP 37 as complete
d8e3b68 
Assigned number 37 to SIP “Quote escapes for interpolations”.

Implemented in Scala 2.13.6 in scala/scala#9536
Implemented in Scala 3.0.0 in scala/scala3#7486
julienrf added a commit to scala/improvement-proposals that referenced this pull request Jun 9, 2022
@julienrf
Mark SIP 37 as complete
fbd9d70 
Assigned number 37 to SIP “Quote escapes for interpolations”.

Implemented in Scala 2.13.6 in scala/scala#9536
Implemented in Scala 3.0.0 in scala/scala3#7486
@som-snytt som-snytt mentioned this pull request Jun 15, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dottybot dottybot dottybot left review comments

@odersky odersky odersky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@martijnhoekstra @odersky @dottybot