Do not add self-invoke evidence in parser #9577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The RHS of an auxiliary constructor should have implicit args supplied by typer as usual, not using current args in parser, which could only work if all alternatives of the overloaded constructor have the same implicit parameters.
dwijnand
reviewed
Apr 19, 2021
|
When the restriction against mixing context bounds and implicits was lifted pre-2.10, this bit should have been removed, modulo other restrictions. I lost patience looking for when that happened. Presumably the original restriction was enforced for a reason. |
lrytz
approved these changes
Apr 20, 2021
|
@lrytz Seth asked on the ticket, I will amend the comment so you don't have to skip the joke part. scala/bug#12233 (comment) |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The RHS of an auxiliary constructor should have
implicit args supplied by typer as usual,
not using current args in parser, which could
only work if all alternatives of the overloaded
constructor have the same implicit parameters.
Fixes scala/bug#12233