Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt vulpix to SAM types #2967

Closed
felixmulder opened this issue Aug 9, 2017 · 3 comments
Closed

Adapt vulpix to SAM types #2967

felixmulder opened this issue Aug 9, 2017 · 3 comments

Comments

@felixmulder
Copy link
Contributor

When moving to >= 2.12 after #2827 is merged, we can make vulpix use SAM types instead of doing things like:

new Runnable { ... } we can do () => { ... }.

@3shv
Copy link

3shv commented Aug 23, 2017

I can work on this. So, only the files under the package dotty.tools.vulpix should be affected right?

@felixmulder
Copy link
Contributor Author

That is correct, but if you want, you can also adapt the things in the dotty.tools.dotc.interactive package IIRC :)

3shv pushed a commit to 3shv/dotty that referenced this issue Aug 23, 2017
@3shv
Copy link

3shv commented Aug 23, 2017

Raised a PR here
I found only two places where () => {...} it can be used. Please have a look and let me know if its fine.

3shv pushed a commit to 3shv/dotty that referenced this issue Aug 23, 2017
3shv pushed a commit to 3shv/dotty that referenced this issue Aug 23, 2017
allanrenucci added a commit that referenced this issue Mar 26, 2018
Fix #2967: Adapt Vulpix, InteractiveDriver to SAM types
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants