Make dotty compile with 2.12.3 #2827

felixmulder · 2017-07-03T13:33:00Z

This PR makes dotty compile with 2.12.3

TODO

~~Fix warnings (discussed the Eta-expansion errors, we will not be fixing them)~~
~~Implement JFunctionX methods that were left with a UnsupportedOperationException~~
Remove dependency on JFunctionX/JProcedureX
Fix trait encoding for 2.12 compiled traits (@odersky, but @felixmulder will have a look as well)
~~Reimplement FunctionalInterfaces~~ kept the interfaces instead
Fix scala2 library tests
Bump version number?

smarter · 2017-07-04T09:16:23Z

project/Build.scala

@@ -461,7 +461,7 @@ object Build {

      // get libraries onboard
      libraryDependencies ++= Seq("com.typesafe.sbt" % "sbt-interface" % sbtVersion.value,
-                                  ("org.scala-lang.modules" %% "scala-xml" % "1.0.1").withDottyCompat(),
+                                  "org.scala-lang.modules" %% "scala-xml" % "1.0.6",


Until you change withDottyCompat, you can rewrite this to:

"org.scala-lang.modules" % "scala-xml_2.12" % "1.0.6",

felixmulder · 2017-07-04T12:19:26Z

@sjrd - you removed the BoxesRuntime hash methods in 2.12 :)

sjrd · 2017-07-04T12:35:48Z

Apparently I also removed that very test from Scala 2.12, so it's indeed irrelevant.

odersky · 2017-07-09T17:00:59Z

It seems the error is that it does not find ## in ScalaRunTime.

smarter · 2017-07-09T17:08:55Z

There's multiple errors (see 01ff24f for some tests that fail at runtime due to some issues with the mixin encoding), but that's one of the issue yes, see scala/scala@cce7016 for what changed in Scalac (this commit only deprecated ScalaRunTime.hash but it got removed in a subsequent commit).

odersky · 2017-08-07T07:56:56Z

I fixed the mixin encoding problem that showed up in unittest_collection. I could not reproduce the LazyValsLong problem. @felixmulder can you take over?

felixmulder · 2017-08-07T08:03:07Z

Thanks @odersky, we'll take it from here, enjoy your vacay! 🍹 🏖

2.12 seems to always assume the enclsing mixin class as the type of the "$this" self parameter of a mixin implementation method whereas 2.11 used the self type of this class instead. This commit compensates or the difference.

The dotty fixes were ported from the dotty-library branch, we are now using a new branch at https://github.com/lampepfl/scala/commits/dotty-library2.12

See discussion at https://gitter.im/scala/contributors?at=598b4b3eee5c9a4c5fa61568

scala-xml 1.0.1 isn't published for 2.12

felixmulder · 2017-08-22T17:06:46Z

Merging as @smarter approved in person 🎉

rom1dep · 2017-08-29T02:54:58Z

project/Build.scala

@@ -35,7 +35,7 @@ object ExposedValues extends AutoPlugin {

 object Build {

-  val scalacVersion = "2.11.11" // Do not rename, this is grepped in bin/common.
+  val scalacVersion = "2.12.2" // Do not rename, this is grepped in bin/common.


Maybe I'm missing something, but this series isn't updating bin/common for 2.12, is it intentional?

It wasn't intentional,no. But, we are aware: #3026

If you think you can fix the ./bin/* scripts, then we'd be more than happy to accept a PR! :)

Great, until now I hadn't even noticed that there is both ./bin and ./dist/bin ;)

felixmulder added this to the 0.3 Tech Preview milestone Jul 3, 2017

smarter reviewed Jul 4, 2017

View reviewed changes

felixmulder force-pushed the topic/goto-2.12 branch from 8477039 to c6a6926 Compare July 4, 2017 12:28

felixmulder force-pushed the topic/goto-2.12 branch from c6a6926 to 7e0de14 Compare July 4, 2017 12:42

smarter mentioned this pull request Jul 10, 2017

Dotty 0.2.0-RC1 release announcement draft. #2844

Merged

felixmulder force-pushed the topic/goto-2.12 branch 2 times, most recently from 38b0674 to f745117 Compare August 9, 2017 15:05

felixmulder mentioned this pull request Aug 9, 2017

Adapt vulpix to SAM types #2967

Closed

smarter changed the title ~~[WIP] Make dotty compile with 2.12.2~~ [WIP] Make dotty compile with 2.12.3 Aug 10, 2017

felixmulder changed the title ~~[WIP] Make dotty compile with 2.12.3~~ Make dotty compile with 2.12.3 Aug 15, 2017

felixmulder and others added 14 commits August 22, 2017 16:05

Make dotty compile with 2.12.2

0f7d251

Remove unused ScalaRunTime

c4ff41f

Make tests compatible with 2.12

2169066

Annotate errors for @odersky

cc83125

Blacklist ScalaRuntime from compiling in compileStdLib tests

a081451

Fix blacklisting of ScalaRunTime

47c9f00

Fix 2.12 self types in mixin translation

3cf589a

2.12 seems to always assume the enclsing mixin class as the type of the "$this" self parameter of a mixin implementation method whereas 2.11 used the self type of this class instead. This commit compensates or the difference.

Adapt test to 2.12.x

a17c688

Fix issue with anyHash in ScalaRuntime

d414359

Update specs2 version

e0f9176

Temporarily fix broken type inferencing in test numbereq.scala

92d10b5

Remove test taking 100 seconds to run

9c478a2

Work around type comparer bug in mixins test

76c3ae3

Fix position used in variance error message

cd74b12

smarter added 5 commits August 22, 2017 16:05

Upgrade scala2-library to 2.12 + dotty fixes

0fb6cf6

The dotty fixes were ported from the dotty-library branch, we are now using a new branch at https://github.com/lampepfl/scala/commits/dotty-library2.12

Fix compileMixed test

0c44b9b

dotty.runtime.LazyVals: Fix for 2.12 shifting semantics

7b757b0

See discussion at https://gitter.im/scala/contributors?at=598b4b3eee5c9a4c5fa61568

Fix example-project sbt test

b3d9063

scala-xml 1.0.1 isn't published for 2.12

Upgrade to 2.12.3

98488f8

felixmulder force-pushed the topic/goto-2.12 branch 3 times, most recently from 1835fa2 to 81b95a6 Compare August 22, 2017 15:25

felixmulder added 2 commits August 22, 2017 17:27

Bump version from 2.11 release to 2.12 series

40c7f2c

Fix new warnings in dotty-compiler

97ed06e

felixmulder force-pushed the topic/goto-2.12 branch from 81b95a6 to 97ed06e Compare August 22, 2017 15:27

felixmulder merged commit b0d3861 into scala:master Aug 22, 2017

rom1dep reviewed Aug 29, 2017

View reviewed changes

allanrenucci deleted the topic/goto-2.12 branch December 14, 2017 19:25

smarter mentioned this pull request Jan 11, 2018

Errors when producing jar using sbt-assembly #2661

Closed

nicolasstucki mentioned this pull request Nov 22, 2021

GraalVM Native Image Requires Config for lazy vals #13985

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make dotty compile with 2.12.3 #2827

Make dotty compile with 2.12.3 #2827

felixmulder commented Jul 3, 2017 •

edited by smarter

smarter Jul 4, 2017

felixmulder commented Jul 4, 2017

sjrd commented Jul 4, 2017

odersky commented Jul 9, 2017

smarter commented Jul 9, 2017

odersky commented Aug 7, 2017 •

edited

felixmulder commented Aug 7, 2017

felixmulder commented Aug 22, 2017

rom1dep Aug 29, 2017

felixmulder Aug 29, 2017

rom1dep Aug 29, 2017

Make dotty compile with 2.12.3 #2827

Make dotty compile with 2.12.3 #2827

Conversation

felixmulder commented Jul 3, 2017 • edited by smarter

TODO

smarter Jul 4, 2017

Choose a reason for hiding this comment

felixmulder commented Jul 4, 2017

sjrd commented Jul 4, 2017

odersky commented Jul 9, 2017

smarter commented Jul 9, 2017

odersky commented Aug 7, 2017 • edited

felixmulder commented Aug 7, 2017

felixmulder commented Aug 22, 2017

rom1dep Aug 29, 2017

Choose a reason for hiding this comment

felixmulder Aug 29, 2017

Choose a reason for hiding this comment

rom1dep Aug 29, 2017

Choose a reason for hiding this comment

felixmulder commented Jul 3, 2017 •

edited by smarter

odersky commented Aug 7, 2017 •

edited