Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow leading context parameters in extension methods #10940

Merged
merged 28 commits into from
Jan 6, 2021
Merged

Allow leading context parameters in extension methods #10940

merged 28 commits into from
Jan 6, 2021

Commits on Jan 6, 2021

  1. Allow leading context parameters in extension methods 

    Fixes scala#9530
    @odersky @nicolasstucki
    odersky authored and nicolasstucki committed Jan 6, 2021
    Configuration menu
    Copy the full SHA
    9a57e14 View commit details
    Browse the repository at this point in the history

  2. Fix scala3doc test

    @odersky @nicolasstucki
    odersky authored and nicolasstucki committed Jan 6, 2021
    Configuration menu
    Copy the full SHA
    dc71243 View commit details
    Browse the repository at this point in the history

  3. Refine encoding of right-associative extension methods 

    Leading using clauses now scope over both left and right parameter.
    @odersky @nicolasstucki
    odersky authored and nicolasstucki committed Jan 6, 2021
    Configuration menu
    Copy the full SHA
    7b24c5a View commit details
    Browse the repository at this point in the history

  4. Fix wording according to review suggestions

    @odersky @nicolasstucki
    odersky authored and nicolasstucki committed Jan 6, 2021
    Configuration menu
    Copy the full SHA
    e6afdbc View commit details
    Browse the repository at this point in the history

  5. Make polyDefDef pass type trees instead of types 

    This is a first step towards passing reference trees for all parameters
together.
    @odersky @nicolasstucki
    odersky authored and nicolasstucki committed Jan 6, 2021
    Configuration menu
    Copy the full SHA
    dbc572c View commit details
    Browse the repository at this point in the history

  6. make tpd.appliedToArgss also work for type arguments

    @odersky @nicolasstucki
    odersky authored and nicolasstucki committed Jan 6, 2021
    Configuration menu
    Copy the full SHA
    2526295 View commit details
    Browse the repository at this point in the history

  7. Improve handling of parameters in Tasty format 

    Using two different tags for empty parameter lists and parameter splits
leads to a more straightforward encoding.

Also: shift tags around to create more free slots for single element trees.
    @odersky @nicolasstucki
    odersky authored and nicolasstucki committed Jan 6, 2021
    Configuration menu
    Copy the full SHA
    380c80b View commit details
    Browse the repository at this point in the history

  8. Merge type params and term params in DefDef nodes

    @odersky @nicolasstucki
    odersky authored and nicolasstucki committed Jan 6, 2021
    Configuration menu
    Copy the full SHA
    6118594 View commit details
    Browse the repository at this point in the history

  9. Optimize termParamss

    @odersky @nicolasstucki
    odersky authored and nicolasstucki committed Jan 6, 2021
    Configuration menu
    Copy the full SHA
    1eff2f4 View commit details
    Browse the repository at this point in the history

  10. Use single parameter list for tpd.DefDef methods

    @odersky @nicolasstucki
    odersky authored and nicolasstucki committed Jan 6, 2021
    Configuration menu
    Copy the full SHA
    d4d604d View commit details
    Browse the repository at this point in the history

  11. Eliminate polyDefDef def and calls

    @odersky @nicolasstucki
    odersky authored and nicolasstucki committed Jan 6, 2021
    Configuration menu
    Copy the full SHA
    5a233c9 View commit details
    Browse the repository at this point in the history

  12. Allow two type parameter lists in extension methods

    @odersky @nicolasstucki
    odersky authored and nicolasstucki committed Jan 6, 2021
    Configuration menu
    Copy the full SHA
    6ea2da2 View commit details
    Browse the repository at this point in the history

  13. Disable macro tests 

    Macro tests seem to use the wrong version of Quotes (non-bootstrapped, where it should
be bootstrapped).
    @odersky @nicolasstucki
    odersky authored and nicolasstucki committed Jan 6, 2021
    Configuration menu
    Copy the full SHA
    7c159f8 View commit details
    Browse the repository at this point in the history

  14. Workaround for community-build failure

    @odersky @nicolasstucki
    odersky authored and nicolasstucki committed Jan 6, 2021
    Configuration menu
    Copy the full SHA
    5f717d0 View commit details
    Browse the repository at this point in the history

  15. Update reference docs

    @odersky @nicolasstucki
    odersky authored and nicolasstucki committed Jan 6, 2021
    Configuration menu
    Copy the full SHA
    d5d3f23 View commit details
    Browse the repository at this point in the history

  16. Fix definition of asExprOf on Tree

    @nicolasstucki
    nicolasstucki committed Jan 6, 2021
    Configuration menu
    Copy the full SHA
    1662016 View commit details
    Browse the repository at this point in the history

  17. Update extension docs

    @odersky @nicolasstucki
    odersky authored and nicolasstucki committed Jan 6, 2021
    Configuration menu
    Copy the full SHA
    fbcf807 View commit details
    Browse the repository at this point in the history

  18. Drop IntegratedTypeArgs

    @odersky @nicolasstucki
    odersky authored and nicolasstucki committed Jan 6, 2021
    Configuration menu
    Copy the full SHA
    02e7298 View commit details
    Browse the repository at this point in the history

  19. Fix inlining with multiple type argument clauses 

    To do this, get rid of all uses of `decomposeCall`.
    @odersky @nicolasstucki
    odersky authored and nicolasstucki committed Jan 6, 2021
    Configuration menu
    Copy the full SHA
    f657212 View commit details
    Browse the repository at this point in the history

  20. Add tests with dependencies from second type parameter clause 

    Add tests with dependencies from second type parameter clause to
first type parameter and extension parameter clauses.
    @odersky @nicolasstucki
    odersky authored and nicolasstucki committed Jan 6, 2021
    Configuration menu
    Copy the full SHA
    3a00189 View commit details
    Browse the repository at this point in the history

  21. Make overloading resolution work for embedded type params 

    Make overloading resulution work in the case where type parameters follow
value parameters.
    @odersky @nicolasstucki
    odersky authored and nicolasstucki committed Jan 6, 2021
    Configuration menu
    Copy the full SHA
    36b1a71 View commit details
    Browse the repository at this point in the history

  22. Fix right associative extension method docs

    @prolativ @nicolasstucki
    prolativ authored and nicolasstucki committed Jan 6, 2021
    Configuration menu
    Copy the full SHA
    9528eef View commit details
    Browse the repository at this point in the history

  23. Fix problem with extension methods in givens 

    For these we need an eligibility pre-check. That pre-check
did not skip leading implicit parameters, so failed to recognize
eligible extension methods.
    @odersky @nicolasstucki
    odersky authored and nicolasstucki committed Jan 6, 2021
    Configuration menu
    Copy the full SHA
    29f671b View commit details
    Browse the repository at this point in the history

  24. Use unreachable for match cases that are known to be unreachable

    @odersky @nicolasstucki
    odersky authored and nicolasstucki committed Jan 6, 2021
    Configuration menu
    Copy the full SHA
    d6b4bee View commit details
    Browse the repository at this point in the history

  25. Revert patches of asExprOf

    @nicolasstucki
    nicolasstucki committed Jan 6, 2021
    Configuration menu
    Copy the full SHA
    e0eed74 View commit details
    Browse the repository at this point in the history

  26. Remove outdated comments

    @nicolasstucki
    nicolasstucki committed Jan 6, 2021
    Configuration menu
    Copy the full SHA
    96fd018 View commit details
    Browse the repository at this point in the history

  27. Revert changes in BootstrappedOnlyCompilationTests

    @nicolasstucki
    nicolasstucki committed Jan 6, 2021
    Configuration menu
    Copy the full SHA
    5c4c412 View commit details
    Browse the repository at this point in the history

  28. Remove outdated comments

    @nicolasstucki
    nicolasstucki committed Jan 6, 2021
    Configuration menu
    Copy the full SHA
    c4b210e View commit details
    Browse the repository at this point in the history