Add language.deprecated.symbolLiterals import #11588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow symbol literals if a language import
import language.deprecated.symbolLiterals
is given. This is useful for legacy software that uses
symbol literals. A typical case are Spark notebooks, where
column names are expressed with symbol literals.
|
This PR addresses lampepfl/dotty-feature-requests#182. |
bishabosha
reviewed
Mar 5, 2021
| report.errorOrMigrationWarning( | ||
| em"""symbol literal '${in.name} is no longer supported, | ||
| |use a string literal "${in.name}" or an application Symbol("${in.name}") instead, | ||
| |or enclose in braces '{${in.name}} if you want a quoted expression.""", |
There was a problem hiding this comment.
Should this error mention that the use can import language.deprecated.symbolLiterals?
There was a problem hiding this comment.
yes, I think that would be a good idea
smarter
added a commit
to smarter/scala
that referenced
this pull request
Apr 30, 2021
Scala 3 still supports symbol literals even if they require a language import now (cf scala/scala3#11588), so don't emit an error if we find one under -Xsource:3 as that could unnecessarily impede cross-compilation as discovered in scala/scala-dev#769.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow symbol literals if a language import
is given. This is useful for legacy software that uses
symbol literals. A typical case are Spark notebooks, where
column names are expressed with symbol literals.