Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conflicting outer definition in same file: ensure source exists #17439

Closed
wants to merge 4 commits into from
Closed

Conflicting outer definition in same file: ensure source exists #17439

wants to merge 4 commits into from

Commits on Jun 20, 2023

  1. Revert "Revert "Include top-level symbols from same file in outer amb… 

    …iguity error""

This reverts commit ccf2f81.
    @lrytz
    lrytz committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    123a951 View commit details
    Browse the repository at this point in the history

  2. Check only existing conflicting def with source

    @som-snytt @lrytz
    som-snytt authored and lrytz committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    0b52243 View commit details
    Browse the repository at this point in the history

  3. Improve source check of conflicting definition 

    An inherited member cannot shadow a definition in scope
that was defined in the current compilation unit.
Aliases are given a pass of sorts.
Either the member or the definition may be overloaded,
which complicates both detection and mitigation.
Tests are for the status quo.
    @som-snytt @lrytz
    som-snytt authored and lrytz committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    062d9ca View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2023

  1. Package object members are not conflicting with inherited

    @lrytz
    lrytz committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    5740455 View commit details
    Browse the repository at this point in the history