Curried methods are not valid SAM methods #18110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwijnand
approved these changes
Jun 30, 2023
dwijnand
reviewed
Jun 30, 2023
This reverts most of scala#17740 and instead add a check on currying in SAMType. We could consider allowing curried methods in SAM types, but this would be a language change that requires a SIP, and the implementation would need an adaptation step in erasure since the invokedynamic method needs to have a compatible signature with the abstract method in the trait.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts most of #17740 and instead add a check on currying in SAMType. We could consider allowing curried methods in SAM types, but this would be a language change that requires a SIP, and the implementation would need an adaptation step in erasure since the invokedynamic method needs to have a compatible signature with the abstract method in the trait.