Remove double tests of tests/pos
#18683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should not tests all `tests/pos` files twice with another set of flags. Furthermore, in all our tests the result of adding the flags is not checked in any meaningful way. The only tests for this flag (tests/neg-custom-args/fatal-warnings/i17612b/i17612b.scala) does add the flag explicitly and checks the result already. See scala@46f2db6
bishabosha
approved these changes
Oct 12, 2023
WojciechMazur
added a commit
that referenced
this pull request
Jun 20, 2024
Backports #18683 to the LTS branch. PR submitted by the release tooling. [skip ci]
WojciechMazur
added a commit
that referenced
this pull request
Jun 20, 2024
Backports #18683 to the LTS branch. PR submitted by the release tooling. [skip ci]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should not tests all
tests/posfiles twice with another set of flags. Furthermore, in all our tests the result of adding the flags is not checked in any meaningful way. The only tests for this flag (tests/neg-custom-args/fatal-warnings/i17612b/i17612b.scala) does add the flag explicitly and checks the result already.See 46f2db6