Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport "Remove double tests of tests/pos" to LTS #20702

Merged
merged 1 commit into from
Jun 20, 2024
Merged

Conversation

WojciechMazur
Copy link
Contributor

Backports #18683 to the LTS branch.

PR submitted by the release tooling.
[skip ci]

We should not tests all `tests/pos` files twice with another set of flags.
Furthermore, in all our tests the result of adding the flags is not checked
in any meaningful way. The only tests for this flag (tests/neg-custom-args/fatal-warnings/i17612b/i17612b.scala) does add the flag explicitly
and checks the result already.

See 46f2db6

[Cherry-picked b8aae69]
Base automatically changed from lts-18089 to lts-3.3 June 20, 2024 14:57
@WojciechMazur
Copy link
Contributor Author

No regressions detected in the community build up to lts-18731.

Reference

@WojciechMazur WojciechMazur merged commit 89dbf92 into lts-3.3 Jun 20, 2024
19 checks passed
@WojciechMazur WojciechMazur deleted the lts-18683 branch June 20, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants