Stress test for add-class-deps (#18958) #19015
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some test cases that demonstrate that Scala's type system is currently not precise enough when it comes to dependent classes.
For a tracked class parameter we add a refinement in the constructor type that
the class member is the same as the parameter. E.g.
```scala
class C { type T }
class D(tracked val x: C) { type T = x.T }
```
This will generate the constructor type:
```scala
(x1: C): D { val x: x1.type }
```
Without `tracked` the refinement would not be added. This can solve several problems with dependent class
types where previously we lost track of type dependencies.
Needs an addition to Tasty format: TRACKED as a modifier.
This commit makes all explicitly declared vals tracked. It causes many test failures, which makes it unlikely that we will be able to do this in the end. But it's an excellent basis for stress testing the implementation of dependent classes. The idea is to - look at the test failures in this test - convert failing tests into tests witih explicit tracked annotations - if the test still fails (it probably will), try to fix the root cause or determine that the pattern should not be supported.
|
I probably won't have time to work on this. If we want to make progress here it would be good to have somebody pick up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #18958 with one additional commit.
This commit marks all explicitly declared vals tracked. It causes many test failures, which
makes it unlikely that we will be able to do this in the end. But it's an excellent basis
for stress testing the implementation of dependent classes.
The idea is to
trackedmodifiers and compile with Pre SIP: Improvements to Modularity #18958.or determine that the pattern should not be supported.