[WIP] Try other Tuple map method #19600
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EugeneFlesselle
force-pushed
the
tuples/map
branch
from
29ebade
to
7888a52
Compare
| @@ -56,7 +56,7 @@ sealed trait Tuple extends Product { | |||
| * If the tuple is of the form `a1 *: ... *: Tuple` (that is, the tail is not known | |||
| * to be the cons type. | |||
| */ | |||
| inline def map[F[_]](f: [t] => t => F[t]): Map[this.type, F] = | |||
| inline def map[F[_ <: Union[this.type]]](f: (t: Union[this.type]) => F[t.type]): Map[this.type, F] = | |||
There was a problem hiding this comment.
This will break TASTy compatibility. We can avoid this breakage with the trick in #19185.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes in the community-build to cats and spire are not due tu uses of the current
tuple.mapmethod. They both use implicit conversion before applying other definitions ofmapwhich now do not get tried as the new versionmapon tuples has a closer signature.