Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport "Implement -Xlint:private-shadow, type-parameter-shadow" to LTS #20628

Merged
merged 11 commits into from
Jun 20, 2024
Merged

Backport "Implement -Xlint:private-shadow, type-parameter-shadow" to LTS #20628

merged 11 commits into from
Jun 20, 2024

Commits on Jun 19, 2024

  1. Implement -Xlint:private-shadow, type-parameter-shadow 

    Respectively warn about :
- a private field or a class parameter that shadows a superclass field
- a local type parameter that shadows a type already in the scope

Fixes : #17612 and #17613

[Cherry-picked e5fd477]
    @schuetzcarl @WojciechMazur
    schuetzcarl authored and WojciechMazur committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    7982369 View commit details
    Browse the repository at this point in the history

  2. Move out miniphase 

    [Cherry-picked 1f15b29]
    @schuetzcarl @WojciechMazur
    schuetzcarl authored and WojciechMazur committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    6bf61a4 View commit details
    Browse the repository at this point in the history

  3. Fix Exception in CheckUnused isOverriden() helper 

    [Cherry-picked 175d4f3][modified]
    @WojciechMazur
    WojciechMazur committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    9513ea0 View commit details
    Browse the repository at this point in the history

  4. Warn instead of fail for invalid -Xlint args 

    [Cherry-picked 07f6581]
    @schuetzcarl @WojciechMazur
    schuetzcarl authored and WojciechMazur committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    e533cb5 View commit details
    Browse the repository at this point in the history

  5. Lint MegaPhase after ExtractSemanticDB 

    [Cherry-picked 297183c]
    @schuetzcarl @WojciechMazur
    schuetzcarl authored and WojciechMazur committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    3bfa727 View commit details
    Browse the repository at this point in the history

  6. Adjust export and synth. case class constructor false-positive cases … 

    …& Add Tests

[Cherry-picked 46f2db6]
    @schuetzcarl @WojciechMazur
    schuetzcarl authored and WojciechMazur committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    5065f83 View commit details
    Browse the repository at this point in the history

  7. Move tests from neg-custom-args/fatal-warnings to neg 

    [Cherry-picked fb8426a]
    @schuetzcarl @WojciechMazur
    schuetzcarl authored and WojciechMazur committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    2596d7a View commit details
    Browse the repository at this point in the history

  8. Delete tests in old folder 

    [Cherry-picked 2edd869]
    @schuetzcarl @WojciechMazur
    schuetzcarl authored and WojciechMazur committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    505b197 View commit details
    Browse the repository at this point in the history

  9. Change options line for tests/neg folder 

    [Cherry-picked 1db2afb]
    @schuetzcarl @WojciechMazur
    schuetzcarl authored and WojciechMazur committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    04988ab View commit details
    Browse the repository at this point in the history

  10. Apply review changes 

    [Cherry-picked e3c984e]
    @schuetzcarl @WojciechMazur
    schuetzcarl authored and WojciechMazur committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    26cc911 View commit details
    Browse the repository at this point in the history

  11. Separate CheckUnused and CheckShadowing into two MegaPhases 

    [Cherry-picked 0f4f7bf]
    @schuetzcarl @WojciechMazur
    schuetzcarl authored and WojciechMazur committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    bb55300 View commit details
    Browse the repository at this point in the history