Skip to content

Backport "Implement -Xlint:private-shadow, type-parameter-shadow" to LTS #20628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Jun 20, 2024
Merged

Backport "Implement -Xlint:private-shadow, type-parameter-shadow" to LTS #20628

merged 11 commits into from
Jun 20, 2024

Conversation

WojciechMazur
Copy link
Contributor

Backports #17622 to the LTS branch.

PR submitted by the release tooling.
[skip ci]

@WojciechMazur WojciechMazur force-pushed the lts-18560 branch 2 times, most recently from 3441f0f to e506690 Compare June 19, 2024 15:11
schuetzcarl and others added 11 commits June 19, 2024 17:39
@schuetzcarl @WojciechMazur
Implement -Xlint:private-shadow, type-parameter-shadow
7982369 
Respectively warn about :
- a private field or a class parameter that shadows a superclass field
- a local type parameter that shadows a type already in the scope

Fixes : #17612 and #17613

[Cherry-picked e5fd477]
@schuetzcarl @WojciechMazur
Move out miniphase
6bf61a4 
[Cherry-picked 1f15b29]
@WojciechMazur
Fix Exception in CheckUnused isOverriden() helper
9513ea0 
[Cherry-picked 175d4f3][modified]
@schuetzcarl @WojciechMazur
Warn instead of fail for invalid -Xlint args
e533cb5 
[Cherry-picked 07f6581]
@schuetzcarl @WojciechMazur
Lint MegaPhase after ExtractSemanticDB
3bfa727 
[Cherry-picked 297183c]
@schuetzcarl @WojciechMazur
Adjust export and synth. case class constructor false-positive cases …
5065f83 
…& Add Tests

[Cherry-picked 46f2db6]
@schuetzcarl @WojciechMazur
Move tests from neg-custom-args/fatal-warnings to neg
2596d7a 
[Cherry-picked fb8426a]
@schuetzcarl @WojciechMazur
Delete tests in old folder
505b197 
[Cherry-picked 2edd869]
@schuetzcarl @WojciechMazur
Change options line for tests/neg folder
04988ab 
[Cherry-picked 1db2afb]
@schuetzcarl @WojciechMazur
Apply review changes
26cc911 
[Cherry-picked e3c984e]
@schuetzcarl @WojciechMazur
Separate CheckUnused and CheckShadowing into two MegaPhases
bb55300 
[Cherry-picked 0f4f7bf]
@WojciechMazur
Copy link
Contributor Author

No regressions detected in the community build up to lts-18731.

Reference

@WojciechMazur WojciechMazur merged commit fd85735 into lts-18560 Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WojciechMazur @schuetzcarl