Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport "Give "did you mean ...?" hints also for simple identifiers" to LTS #20742

Merged
merged 4 commits into from
Jun 23, 2024
Merged

Backport "Give "did you mean ...?" hints also for simple identifiers" to LTS #20742

merged 4 commits into from
Jun 23, 2024

Commits on Jun 23, 2024

  1. Give "did you mean ...?" hints also for simple identifiers 

    Fixes #18682

[Cherry-picked f2e2e3f][modified]
    @WojciechMazur
    WojciechMazur committed Jun 23, 2024
    Configuration menu
    Copy the full SHA
    b7e599a View commit details
    Browse the repository at this point in the history

  2. Improvements to "did you mean ...?" scheme 

     1. Only show accessible members
 2. Show several alternatives if they are at same distance. Unlike Scala 2,
    we do not show alternatives at larger distance. I fear that would produce
    more noise than signal.

Fixes #17067

[Cherry-picked 5ce1ac9]
    @odersky @WojciechMazur
    odersky authored and WojciechMazur committed Jun 23, 2024
    Configuration menu
    Copy the full SHA
    d9a9024 View commit details
    Browse the repository at this point in the history

  3. Update compiler/src/dotty/tools/dotc/reporting/messages.scala 

    Co-authored-by: Jamie Thompson <bishbashboshjt@gmail.com>
[Cherry-picked 094c7aa]
    @odersky @WojciechMazur
    odersky authored and WojciechMazur committed Jun 23, 2024
    Configuration menu
    Copy the full SHA
    b2e31fe View commit details
    Browse the repository at this point in the history

  4. Add untpd.ImportSelector#isUnimport

    @WojciechMazur
    WojciechMazur committed Jun 23, 2024
    Configuration menu
    Copy the full SHA
    c613076 View commit details
    Browse the repository at this point in the history