Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport "Give "did you mean ...?" hints also for simple identifiers" to LTS #20742

Merged
merged 4 commits into from
Jun 23, 2024
Merged

Backport "Give "did you mean ...?" hints also for simple identifiers" to LTS #20742

merged 4 commits into from
Jun 23, 2024

Conversation

WojciechMazur
Copy link
Contributor

Backports #18747 to the LTS branch.

PR submitted by the release tooling.
[skip ci]

WojciechMazur and others added 4 commits June 23, 2024 13:08
@WojciechMazur
Give "did you mean ...?" hints also for simple identifiers
b7e599a 
Fixes #18682

[Cherry-picked f2e2e3f][modified]
@odersky @WojciechMazur
Improvements to "did you mean ...?" scheme
d9a9024 
 1. Only show accessible members
 2. Show several alternatives if they are at same distance. Unlike Scala 2,
    we do not show alternatives at larger distance. I fear that would produce
    more noise than signal.

Fixes #17067

[Cherry-picked 5ce1ac9]
@odersky @WojciechMazur
Update compiler/src/dotty/tools/dotc/reporting/messages.scala
b2e31fe 
Co-authored-by: Jamie Thompson <bishbashboshjt@gmail.com>
[Cherry-picked 094c7aa]
@WojciechMazur
Add untpd.ImportSelector#isUnimport
c613076
Base automatically changed from lts-18760 to lts-3.3 June 23, 2024 22:40
@WojciechMazur
Copy link
Contributor Author

No regressions detected in the community build up to lts-19083.

Reference

@WojciechMazur WojciechMazur merged commit 53fff81 into lts-3.3 Jun 23, 2024
19 checks passed
@WojciechMazur WojciechMazur deleted the lts-18747 branch June 23, 2024 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@WojciechMazur @odersky