Backport "Improve asExprOf cast error formatting" to LTS
#20787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The intention of this change is to make it simpler to read the error
message.
List the expected type and actual type before the expression. This is
usually the most important information and simpler to parse as the
expression can get quite long. For the expected type, the actual type
and the expression, we print the value in the same line if its String
representation has only one line. Otherwise we print it in the next line
with an indentation and extra new line at the end.
Before:
```
java.lang.Exception: Expr cast exception: ((a: scala.Int) => ({
val v: scala.Int = a
Binding.apply[scala.Unit](())
}: Binding[scala.Unit]))
of type: scala.Function1[scala.Int, scala.Unit]
did not conform to type: scala.Function1[scala.Int, Binding[scala.Unit]]
at scala.quoted.runtime.impl.QuotesImpl.asExprOf(QuotesImpl.scala:76)
...
```
Example from #19191
After:
```
scala.quoted.runtime.impl.ExprCastException:
Expected type: scala.Function1[scala.Int, scala.Unit]
Actual type: scala.Function1[scala.Int, Binding[scala.Unit]]
Expression:
((a: scala.Int) => ({
val v: scala.Int = a
Binding.apply[scala.Unit](())
}: Binding[scala.Unit]))
at scala.quoted.runtime.impl.QuotesImpl.asExprOf(QuotesImpl.scala:...)
...
```
[Cherry-picked 7480582]
|
No regressions detected in the community build up to lts-19356. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports #19195 to the LTS branch.
PR submitted by the release tooling.
[skip ci]