Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always use Module suffix for abstract modules in TASTy Reflect #5576

Merged
merged 1 commit into from
Dec 7, 2018
Merged

Always use Module suffix for abstract modules in TASTy Reflect #5576

merged 1 commit into from
Dec 7, 2018

Conversation

nicolasstucki
Copy link
Contributor

Also use API (uppercase) consistently and add some docs

@nicolasstucki
Always use Module suffix for abstract modules in TASTy Reflect
7d26ea5 
Also use API (uppercase) consistently and add some docs
@nicolasstucki
Copy link
Contributor Author

Extracted from #5438 and completed.

liufengyun
liufengyun approved these changes Dec 7, 2018
View reviewed changes
Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nicolasstucki nicolasstucki merged commit f256a73 into scala:master Dec 7, 2018
@nicolasstucki nicolasstucki deleted the tasty-reflect-rename-modules branch December 7, 2018 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liufengyun liufengyun liufengyun approved these changes

Assignees

@nicolasstucki nicolasstucki

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicolasstucki @liufengyun