Rename “isosurface“ to “adHocMesh” in code

[frcroth]

Ad-hoc meshing may be a better term, backend still uses "isosurface", which is a quite general term (MATLAB legacy?)

[fm3]

Yes, I’d say we should rename isosurface to adHocMesh in our code. I think we already decided to hide the term isosurface from the users. Adapting the code is the logical next step.

( Any objections @philippotto @normanrz ? )

[philippotto]

Yes, I’d say we should rename isosurface to adHocMesh in our code. I think we already decided to hide the term isosurface from the users. Adapting the code is the logical next step.

I agree 👍

[frcroth]

Do it after #7244

[frcroth]

What is the scope of this issue? I did the renaming in the backend, which was straight-forward, however looking at the front-end, isosurface seems to have a slightly different meaning, because there are PrecomputedIsosurfaces and AdHocIsosurfaces, so I'm not sure what to do here.

[fm3]

@philippotto could you comment on that? My guess is that we can safely rename AdHocIsosurfaces to AdHocMesh – should we also rename PrecomputedIsosurfaces in the frontend to PrecomputedMeshes? Do you see any dangers/problems there?

[philippotto]

What is the scope of this issue? I did the renaming in the backend, which was straight-forward, however looking at the front-end, isosurface seems to have a slightly different meaning, because there are PrecomputedIsosurfaces and AdHocIsosurfaces, so I'm not sure what to do here.

The front-end uses isosurface as a synonym to mesh. So, the necessary renaming would be isosurface -> mesh. Feel free to do the renaming in the front-end, too.

[philippotto]

@philippotto could you comment on that? My guess is that we can safely rename AdHocIsosurfaces to AdHocMesh – should we also rename PrecomputedIsosurfaces in the frontend to PrecomputedMeshes? Do you see any dangers/problems there?

I only just saw your comment. I don't see any problems with that. Renaming to PrecomputedMeshes should be fine.