Update deprecated antd <Menu> #6860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hotzenklotz
force-pushed
the
navbar-menu
branch
from
fdd53e6
to
c987ebf
Compare
|
Mhm, I just realized that this CI error did not occur locally since I already upgrade to the latest antd v4.28.x locally. It seems like the |
…bar-menu * 'master' of github.com:scalableminds/webknossos: Fix exploring datasets via http (without s) (#6863)
philippotto
requested changes
Feb 21, 2023
| icon: any; | ||
| }) { | ||
| if (collapse) { | ||
| return <span title={title}>{icon}</span>; |
There was a problem hiding this comment.
no title anymore? the title makes sure a tooltip is shown when only an icon is visible due to collapsing.
There was a problem hiding this comment.
I think this is still missing? There are no tooltips in the tracing view with a small screen (see screenshot):
There was a problem hiding this comment.
I added a . Should be fixed now.
|
Thanks for the review. I applied your feedback. |
hotzenklotz
added a commit
that referenced
this pull request
Feb 22, 2023
…d-v4.24 * 'master' of github.com:scalableminds/webknossos: Update deprecated antd <Menu> (#6860)
hotzenklotz
added a commit
that referenced
this pull request
Mar 6, 2023
…come_header_UI * 'master' of github.com:scalableminds/webknossos: (34 commits) Slim down view mode dropdown by using icons (#6900) Logging on password reset/change (#6901) When merging volume tracings, also merge segment lists (#6882) avoid spinner when switching tabs in dashboard (#6894) Upgrade Antd to v4.24 (#6865) Support n5 end-chunks with chunksize differing from metadata chunksize (#6890) Implement http range requests for HttpsSeekableByteChannel (#6869) new GH action for adding issues to project board Fix links in Changelog (#6881) adds dedicated explore method for zarr datasets with a datasource-properties.json (#6879) Release 23.03.0 (#6880) Fix superUser being wrongly marked as organization owners (#6876) Followups for OME-TIFF export (#6874) Fix reload-precomputed-mesh functionality (#6875) Adds OME-TIFF export (#6838) Add evolutions 99,100 to migration guide (#6871) Add link to imprint and privacy to help menu (#6870) Annotation Locking Mechanism (#6819) Update deprecated antd <Menu> (#6860) Add functions to get and set segment colors to the frontend API (#6853) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We regularly have depreacation warning in the browser dev tools that antd's
<Menu>{children}</Menu>HOC has been replaced with anitemsprop:<Menu items={...}>.The recommend upgrade path from antd v4 to v5 is to fix all these deprecation warnings. In this pull request I fixed the
<Navbar>and<FolderTree>menus.URL of deployed dev instance (used for testing):
Steps to test:
Issues:
(Please delete unneeded items, merge only when none are left open)