Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Antd to v4.24 #6865

Merged
merged 19 commits into from
Mar 3, 2023
Merged

Upgrade Antd to v4.24 #6865

merged 19 commits into from
Mar 3, 2023

Conversation

hotzenklotz
Copy link
Member

@hotzenklotz hotzenklotz commented Feb 21, 2023

"Simple" PR to upgrade antd from our current version 4.23.x to the latest 4.x release, v4.24.8.

The most relevant changelog is probably from the minor version patch:
See https://github.com/ant-design/ant-design/releases/tag/4.24.0

I have tested this version and everything seems to be in order. On the dev tools CLI there is now a deprecation warning for Dropdown overlay={...} which should be replaced with Dropdown menu={...}. I will tackle that in a different PR though.

Steps to test:

  • Check the CI for listing, typing error
  • Click through tracing UI

Issues:


(Please delete unneeded items, merge only when none are left open)

@hotzenklotz hotzenklotz self-assigned this Feb 21, 2023
@hotzenklotz hotzenklotz mentioned this pull request Feb 21, 2023
12 tasks
…bar-menu

* 'master' of github.com:scalableminds/webknossos:
  Fix style of connectome tab by restricting directory tree style (#6864)
  Remove legacy datasets tab and use new compact route (#6834)
  Fix basicauth for exploring remote http datasets (#6866)
…bar-menu

* 'master' of github.com:scalableminds/webknossos:
  Add functions to get and set segment colors to the frontend API (#6853)
  Ensure that segments are added to segment list when using quick select... (#6867)
Base automatically changed from navbar-menu to master February 22, 2023 15:51
@hotzenklotz hotzenklotz marked this pull request as ready for review February 22, 2023 15:51
…d-v4.24

* 'master' of github.com:scalableminds/webknossos:
  Update deprecated antd <Menu> (#6860)
@philippotto
Copy link
Member

One my laptop screen the dashboard layout is a bit broken:
image

Also the distance between the bell icon and the avatar seems larger than on master.
image
vs
image

Other than that, I couldn't find any problems 👍

…d-v4.24

* 'master' of github.com:scalableminds/webknossos:
  Implement http range requests for HttpsSeekableByteChannel (#6869)
  new GH action for adding issues to project board
  Fix links in Changelog (#6881)
  adds dedicated explore method for zarr datasets with a datasource-properties.json (#6879)
  Release 23.03.0 (#6880)
  Fix superUser being wrongly marked as organization owners (#6876)
  Followups for OME-TIFF export (#6874)
  Fix reload-precomputed-mesh functionality (#6875)
  Adds OME-TIFF export (#6838)
  Add evolutions 99,100 to migration guide (#6871)
  Add link to imprint and privacy to help menu (#6870)
  Annotation Locking Mechanism (#6819)
@hotzenklotz
Copy link
Member Author

@philippotto I applied your PR feedback.

Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hotzenklotz hotzenklotz merged commit e1cb5b8 into master Mar 3, 2023
@hotzenklotz hotzenklotz deleted the antd-v4.24 branch March 3, 2023 13:10
hotzenklotz added a commit that referenced this pull request Mar 3, 2023
…pdown-menu

* 'master' of github.com:scalableminds/webknossos:
  Upgrade Antd to v4.24 (#6865)
  Support n5 end-chunks with chunksize differing from metadata chunksize (#6890)
hotzenklotz added a commit that referenced this pull request Mar 6, 2023
…come_header_UI

* 'master' of github.com:scalableminds/webknossos: (34 commits)
  Slim down view mode dropdown by using icons (#6900)
  Logging on password reset/change (#6901)
  When merging volume tracings, also merge segment lists (#6882)
  avoid spinner when switching tabs in dashboard (#6894)
  Upgrade Antd to v4.24 (#6865)
  Support n5 end-chunks with chunksize differing from metadata chunksize (#6890)
  Implement http range requests for HttpsSeekableByteChannel (#6869)
  new GH action for adding issues to project board
  Fix links in Changelog (#6881)
  adds dedicated explore method for zarr datasets with a datasource-properties.json (#6879)
  Release 23.03.0 (#6880)
  Fix superUser being wrongly marked as organization owners (#6876)
  Followups for OME-TIFF export (#6874)
  Fix reload-precomputed-mesh functionality (#6875)
  Adds OME-TIFF export (#6838)
  Add evolutions 99,100 to migration guide (#6871)
  Add link to imprint and privacy to help menu (#6870)
  Annotation Locking Mechanism (#6819)
  Update deprecated antd <Menu> (#6860)
  Add functions to get and set segment colors to the frontend API (#6853)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants