Redesign right-hand info sidebar #7110

hotzenklotz · 2023-05-31T15:31:42Z

PR slightly redesigns the right-hand info sidebar to be more in line with the new branding and design language.

Changes:

redesigned right-hand side bar info tab for View mode and Annotation mode
moved the AI Segmentation modals to the "main" annotation menu
- refined wording a bit
- renamed the modals to "AI Segmentation". The word inferral is very techy.
added new icons

URL of deployed dev instance (used for testing):

https://redesignrightsidebar.webknossos.xyz/

Steps to test:

Open any DS in "view" and "annotation" modes
Share them with yourself and try view as anonymous user
Add descriptions and names to DS and annotations
Try in dark mode

Issues:

fixes Redesign info tab in right sidebar #7097

(Please delete unneeded items, merge only when none are left open)

Updated changelog
Updated migration guide if applicable
Updated documentation if applicable
Adapted wk-libs python client if relevant API parts change
Removed dev-only changes like prints and application.conf edits
Considered common edge cases
Needs datastore update after deployment

public/images/icon-mouse-left-drag.svg

…esign-right-sidebar * 'master' of github.com:scalableminds/webknossos: When adding annotation layer, assert no duplicate names (#7103) Add folders to dataset table (#6996)

…esign-right-sidebar * 'master' of github.com:scalableminds/webknossos: Create bounding box by dragging with box tool (#7118) Prevent 'negative' buckets from being created (#7124) Lazy load onnx and canvas2html module (#7121) Disable editing of super voxel skeletons in skeleton mode (#7086) add missing evolution to migration guide (#7126) Change sttp backend to HttpURLConnectionBackend (#7125) Implement Zarr v3 and sharding codec (#7079) Fix decompression of garbage data after valid gzip data causing decompression to fail (#7119) When scanning volume buckets, skip those with unparseable key (#7115)

philippotto

Superb stuff 👍 This looks like a very big design increment 🥇 Will test now.

public/images/icon-mouse-left.svg

frontend/javascripts/oxalis/view/right-border-tabs/starting_job_modals.tsx

frontend/javascripts/oxalis/view/right-border-tabs/dataset_info_tab_view.tsx

philippotto · 2023-06-08T12:42:13Z

frontend/javascripts/oxalis/view/right-border-tabs/dataset_info_tab_view.tsx

            </tbody>
          </table>
-          {this.renderSelectedStartingJobsModal()}


so, these actions can only be triggered from an annotation (instead of from the dataset view) now, right?

Good catch. That was not intentional. I think this menu entry should be available in both situations. Will fix.

philippotto · 2023-06-08T13:00:22Z

My findings from testing:

1.1) cog icon goes to new line when DS name is too long
1.2 + 1.3) text color is too light in comparison to dataset description and shortcut intro. in the original design, this was more consistent I think.

2.1) the shortcuts "tags" are too bright in dark mode. maybe this is automatically better when the text gets brighter, too. if not, I'd tone it done a bit with sth like opacity: 0.85.

3.1) the edit-icon is over the text if the text has an unlucky length.
3.2) the margin betwen statistics-headline and statistics-content is too large (at least when compared with the margin above the stats-headline).

4.1 + 4.2) the line thickness of these icons seems to be narrower when compared to the other icons. this makes them a bit harder to see in my opinion.

…esign-right-sidebar * 'master' of github.com:scalableminds/webknossos: Fix true brush size for small, uneven brush sizes (#7129)

…b_modals.tsx Co-authored-by: Philipp Otto <philippotto@users.noreply.github.com>

…knossos into redesign-right-sidebar * 'redesign-right-sidebar' of github.com:scalableminds/webknossos: Update frontend/javascripts/oxalis/view/right-border-tabs/starting_job_modals.tsx Update frontend/javascripts/oxalis/view/right-border-tabs/starting_job_modals.tsx

frontend/javascripts/oxalis/view/right-border-tabs/dataset_info_tab_view.tsx

…o_tab_view.tsx Co-authored-by: Philipp Otto <philippotto@users.noreply.github.com>

…knossos into redesign-right-sidebar * 'redesign-right-sidebar' of github.com:scalableminds/webknossos: Update frontend/javascripts/oxalis/view/right-border-tabs/dataset_info_tab_view.tsx

…esign-right-sidebar * 'master' of github.com:scalableminds/webknossos: Layer actions overflow menu (#7123) Unify DatasetPath and VaultPath, cleaner ChunkReader creation (#7134) Segment to Bucket Index for Volume Annotations (#7063) Reverse compression on sharded neuroglancer datasets (#7135)

…esign-right-sidebar * 'master' of github.com:scalableminds/webknossos: quick fixes for overflow menu (#7138)

frontend/javascripts/oxalis/view/right-border-tabs/dataset_info_tab_view.tsx

…esign-right-sidebar * 'master' of github.com:scalableminds/webknossos: added Youtube videos to docs Log dataset uploads (with no conversion) to slack (#7157) Added "Automation Tutorial" to docs (#7160) fix logo image in README.md Second try for “Async IO for HttpsDataVault, Fox Error Handling” (#7155) Revert "Async IO for HttpsDataVault, Fox Error Handling (#7137)" (#7154) Async IO for HttpsDataVault, Fox Error Handling (#7137) Fix vault path for precomputed datasets (#7151) Add extended keyboard shortcut mode via ctrl + k for tool shortcuts (#7112) Shared Chunk Cache for all DatasetArrays, CacheWeight for AlfuCache (#7067)

hotzenklotz · 2023-06-21T05:58:39Z

@philippotto Anymore review changes or is this free to merge?

philippotto

🚢 🚢 🚢

hotzenklotz added 2 commits May 31, 2023 17:14

added new icons for redesign

3bc0bac

restyling right sidebar

cd38eda

hotzenklotz self-assigned this May 31, 2023

hotzenklotz added the frontend label May 31, 2023

hotzenklotz added 6 commits June 1, 2023 15:30

more styling

34053ea

applied more styling

4fa2361

more tweaks

94cee2b

moved Ai segmentation modals to main tracing menu

c147763

slightly update the Ai segmetnation modal descriptions

d4b0636

fixed formatting and linting

e4095ac

hotzenklotz commented Jun 2, 2023

View reviewed changes

public/images/icon-mouse-left-drag.svg Outdated Show resolved Hide resolved

hotzenklotz added 5 commits June 2, 2023 17:30

changelog

2360f73

Merge branch 'master' of github.com:scalableminds/webknossos into red…

f378a8c

…esign-right-sidebar * 'master' of github.com:scalableminds/webknossos: When adding annotation layer, assert no duplicate names (#7103) Add folders to dataset table (#6996)

only enable AI segmentation for super users

a334f19

update changelog

5dfc4bf

hotzenklotz changed the title ~~WIP Redesign right-hand info sidebar~~ Redesign right-hand info sidebar Jun 8, 2023

hotzenklotz requested a review from philippotto June 8, 2023 09:35

philippotto reviewed Jun 8, 2023

View reviewed changes

hotzenklotz and others added 8 commits June 9, 2023 11:49

Merge branch 'master' of github.com:scalableminds/webknossos into red…

10df37c

…esign-right-sidebar * 'master' of github.com:scalableminds/webknossos: Fix true brush size for small, uneven brush sizes (#7129)

Update frontend/javascripts/oxalis/view/right-border-tabs/starting_jo…

41b4129

…b_modals.tsx Co-authored-by: Philipp Otto <philippotto@users.noreply.github.com>

Update frontend/javascripts/oxalis/view/right-border-tabs/starting_jo…

12f0d3a

…b_modals.tsx Co-authored-by: Philipp Otto <philippotto@users.noreply.github.com>

applied PR feedback

77cf79b

applied PR feedback for segment counts

f1167b6

updated icons due to PR feedback

b7d9138

formatting

9d467ad

philippotto reviewed Jun 12, 2023

View reviewed changes

frontend/javascripts/oxalis/view/right-border-tabs/dataset_info_tab_view.tsx Outdated Show resolved Hide resolved

Update frontend/javascripts/oxalis/view/right-border-tabs/dataset_inf…

69d3388

…o_tab_view.tsx Co-authored-by: Philipp Otto <philippotto@users.noreply.github.com>

hotzenklotz added 3 commits June 14, 2023 08:43

Merge branch 'redesign-right-sidebar' of github.com:scalableminds/web…

92b2d35

…knossos into redesign-right-sidebar * 'redesign-right-sidebar' of github.com:scalableminds/webknossos: Update frontend/javascripts/oxalis/view/right-border-tabs/dataset_info_tab_view.tsx

Merge branch 'master' of github.com:scalableminds/webknossos into red…

2ee7ace

…esign-right-sidebar * 'master' of github.com:scalableminds/webknossos: quick fixes for overflow menu (#7138)

hotzenklotz marked this pull request as ready for review June 14, 2023 07:20

philippotto reviewed Jun 14, 2023

View reviewed changes

frontend/javascripts/oxalis/view/right-border-tabs/dataset_info_tab_view.tsx Outdated Show resolved Hide resolved

hotzenklotz added 6 commits June 14, 2023 11:51

more PR feedback

99d8f59

updated icons

29799f6

fix linting

53f54c2

fix react error messages

f710fa9

add AI segmentation menu to view and annotation modes

1e1170e

hotzenklotz enabled auto-merge (squash) June 21, 2023 05:55

Merge branch 'master' into redesign-right-sidebar

ebccc2b

Merge branch 'master' into redesign-right-sidebar

687a1a5

philippotto approved these changes Jun 21, 2023

View reviewed changes

hotzenklotz merged commit be790b7 into master Jun 21, 2023
2 checks passed

hotzenklotz deleted the redesign-right-sidebar branch June 21, 2023 08:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Redesign right-hand info sidebar #7110

Redesign right-hand info sidebar #7110

hotzenklotz commented May 31, 2023 •

edited

philippotto left a comment

philippotto Jun 8, 2023

hotzenklotz Jun 9, 2023

philippotto commented Jun 8, 2023 •

edited by hotzenklotz

hotzenklotz commented Jun 21, 2023

philippotto left a comment

Redesign right-hand info sidebar #7110

Redesign right-hand info sidebar #7110

Conversation

hotzenklotz commented May 31, 2023 • edited

URL of deployed dev instance (used for testing):

Steps to test:

Issues:

philippotto left a comment

Choose a reason for hiding this comment

philippotto Jun 8, 2023

Choose a reason for hiding this comment

hotzenklotz Jun 9, 2023

Choose a reason for hiding this comment

philippotto commented Jun 8, 2023 • edited by hotzenklotz

hotzenklotz commented Jun 21, 2023

philippotto left a comment

Choose a reason for hiding this comment

hotzenklotz commented May 31, 2023 •

edited

philippotto commented Jun 8, 2023 •

edited by hotzenklotz