Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle issues in Gradle artifact resolution #1369

Merged
merged 4 commits into from
Sep 16, 2020

Conversation

Arthurm1
Copy link
Contributor

@Arthurm1 Arthurm1 commented Sep 5, 2020

This changes the way artifacts (jars) are resolved so that it copes with unresolvable configurations which can pop-up in complex Gradle projects.

This is mainly because I was getting issues with Gradle Crossbuild Scala Plugin

The strict dependencies on main sourceset are no longer needed because the classpath handling is more comprehensive.

@Arthurm1
Copy link
Contributor Author

Arthurm1 commented Sep 6, 2020

I think this failure is unrelated - bloop.bsp.TcpBspProtocolSpec

Earlier failures were due to 2.11. I'd forgotten that the Gradle plugin is released for 2.11 and 2.12. Is there any need for this? We could replace gradle-bloop_2.11 and gradle-bloop_2.12 with a single gradle-bloop and just compile against the latest supported Scala version in Bloop.

Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Not 100% familiar with the gradle plugin, but the changes seem fine and we should be good especially with the tests.

@tgodzik
Copy link
Contributor

tgodzik commented Sep 7, 2020

The test failure is not related for sure.

Copy link
Contributor

@jvican jvican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 This indeed looks good, thanks @Arthurm1

@jvican jvican merged commit cc04d90 into scalacenter:master Sep 16, 2020
@Arthurm1 Arthurm1 deleted the gradle_cross_build_support branch September 29, 2020 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants