Force newest log4j version #1667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turns out Zinc brings in log4j, and despite it all working locally (so no actual way to exploit it), it might cause issues if a company proxy blocks log4j older versions.
ckipp01
approved these changes
Jan 28, 2022
|
I think the root problem is that Bloop depends on an 2 years outdated fork of Zinc instead of depending on the current Zinc, which has the log4j dependency updated. |
|
Good news is that we actually no longer depend on that outdated fork 🥳 We recently merged an update which bumped zinc to newest one and you can already test it out! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out Zinc brings in log4j, and despite it all working locally (so no actual way to exploit it), it might cause issues if a company proxy blocks log4j older versions.