Unblock bloop - upgrade monix and bsp4s#1759
Merged
Merged
Conversation
tgodzik
reviewed
Jul 15, 2022
tgodzik
left a comment
tgodzik
left a comment
Contributor
There was a problem hiding this comment.
I started reviewing a bit, but I still have a way to go. Great work!
| compileProvider = Some(BloopBspServices.DefaultCompileProvider), | ||
| testProvider = Some(BloopBspServices.DefaultTestProvider), | ||
| runProvider = Some(BloopBspServices.DefaultRunProvider), | ||
| debugProvider = None, // todo kpodsiad |
Collaborator
Author
@tgodzik 😸 I wanted to test it a bit locally with Metals and provide more clean explanation/motivation before asking for the review but yeah - go ahead |
Collaborator
Author
|
Ok, tested a bit it with metals - looks like it works fine. |
tgodzik
reviewed
Aug 4, 2022
tgodzik
left a comment
tgodzik
left a comment
Contributor
There was a problem hiding this comment.
I went through the entire PR, that is a lot of great work! I left some questions however to clarify some points and let me understand the PR better.
dos65
force-pushed
the
unblock_bloop
branch
2 times, most recently
from
150d6d6 to
fa215fc
Compare
Replace `monix.eval.Task` usage on `bloop.task.Task`. This allows to keep the same cancellation behaviour as it was in monix2. Co-authored-by: Kamil Podsiadlo <kpodsiadlo@virtuslab.com>
Co-authored-by: Kamil Podsiadlo <kpodsiadlo@virtuslab.com>
tgodzik
approved these changes
Aug 17, 2022
tgodzik
left a comment
tgodzik
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Let's try it out in Metals!
| compileProvider = Some(BloopBspServices.DefaultCompileProvider), | ||
| testProvider = Some(BloopBspServices.DefaultTestProvider), | ||
| runProvider = Some(BloopBspServices.DefaultRunProvider), | ||
| debugProvider = None, // todo kpodsiad |
Contributor
|
Actually, I forgot about this comment: Could you update it with an issue in a follow up @dos65 ? |
Collaborator
Author
|
@tgodzik oh, yep - will do |
dos65
added a commit
to dos65/bloop
that referenced
this pull request
Aug 17, 2022
Follow up to scalacenter#1759 I thought that it was fixed in scalacenter@2baf28a but it seems that I got confused in locally published bloop versions.
This was referenced Aug 17, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.