bugfix: Catch and log StackOverflowError #2001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, when the compiler threw a StackOverflowException Bloop would hang and nver return a results. Now, it logs the proper error and translates the exception. Related to VirtusLab/scala-cli#1781
tgodzik
commented
Jan 30, 2023
| @@ -133,6 +133,10 @@ final class BloopHighLevelCompiler( | |||
| logger | |||
| ) | |||
| } catch { | |||
| case t: StackOverflowError => | |||
| val msg = "Encountered StackOverflowError coming from the compiler. You might need to restart Bloop build server" | |||
| logger.error(s"${msg}:\n${t.getStackTrace().mkString("\n")}") | |||
There was a problem hiding this comment.
No supper happy about this, but it seems the loggers from zinc only allow a single message. This seems to be working alright when it comes to the example issue.
Question: Should we add a test case? This might be fixed in a future version of the compiler, so it would be removed at some point. Also, not sure if throwing stack overflow in a JVM is a best test case 😅
There was a problem hiding this comment.
Honestly, I don't really think we need to add a test for this.
ckipp01
requested changes
Feb 1, 2023
backend/src/main/scala/sbt/internal/inc/bloop/internal/BloopHighLevelCompiler.scala
Outdated
Show resolved
Hide resolved
| @@ -133,6 +133,10 @@ final class BloopHighLevelCompiler( | |||
| logger | |||
| ) | |||
| } catch { | |||
| case t: StackOverflowError => | |||
| val msg = "Encountered StackOverflowError coming from the compiler. You might need to restart Bloop build server" | |||
| logger.error(s"${msg}:\n${t.getStackTrace().mkString("\n")}") | |||
There was a problem hiding this comment.
Honestly, I don't really think we need to add a test for this.
Co-authored-by: Chris Kipp <ckipp@pm.me>
ckipp01
approved these changes
Feb 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when the compiler threw a StackOverflowException Bloop would hang and nver return a results. Now, it logs the proper error and translates the exception.
Related to VirtusLab/scala-cli#1781