-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] publishing to scaladex using sbt publish #176
Conversation
@@ -74,7 +74,8 @@ class ApiImplementation(github: Github, userState: Option[UserState])(implicit v | |||
) | |||
) | |||
).limit(1) | |||
}.map(r => r.as[Project].headOption.map(hideId)) | |||
// }.map(r => r.as[Project].headOption.map(hideId)) | |||
}.map ( r => r.as[Project].headOption) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MasseGuillaume Maybe this will lead to some problems. I guess indexing all data
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what about it ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess it was there for a reason.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep the id was for updating (ProjectDelta)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, then i'll fix that :)
really cool! If I understand well, it's to receive pom from sbt via http and fetch all info to index. On this branch I remove the link between projects and release: Therefore adding a new release will be pretty easy :-) |
Can i already rebase to |
@Scyks almost, if it's too much work I can do it for you. |
0f81816
to
43a2a1d
Compare
|
||
object autoImport { | ||
|
||
lazy val scaladex = TaskKey[Unit]("scaladex-publish", "Publishes to scaladex") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you should create a scaladex
scope and reuse the publish
task
- implementing receiving data from bt publish task - verify credentials to github - only accept pom file - write pom file - update index Todos: - [ ] verify write access to this repo - [ ] check for ovverrides - [ ] cleanup - [ ] rebase to elastic restructuring
The url schema is changed to provide some settings for scaldex - download readme - download info - download contributors - keywords Lookup a release by mavenReference
- refactoring of `PublishProcess` to ensure the user have write access to the repo. - Check the write access - check for publish settings - update project keywords
f630514
to
12b56e9
Compare
Thanks @MasseGauillaume :)
… into publish-to-scaladex
I created a bintray user called scaladex and published a package under https://bintray.com/scaladex/sbt-plugins/sbt-scaladex a request was sent to be included to https://bintray.com/sbt/sbt-plugin-releases
@@ -22,13 +22,15 @@ object ScaladexPlugin extends AutoPlugin { | |||
lazy val scaladexDownloadReadme = settingKey[Boolean]("defines if scaladex should download the readme file from the defined scm tag") | |||
lazy val scaladexDownloadInfo = settingKey[Boolean]("defines if scaladex should download the project info from the defined scm tag") | |||
lazy val scaladexDownloadContributors = settingKey[Boolean]("defines if scaladex should download the contributors from the defined scm tag") | |||
lazy val scaladexBaseUrl = settingKey[String]("scaladex server location and path") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, i wanted to add that also 👍
|
||
## How to run: | ||
## Hot to publish on scaladex |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@heathermiller @MasseGuillaume Could one of you maybe check the description of errors / miss understanding / mistakes.
import play.api.libs.ws.ahc.AhcWSClient | ||
|
||
import scala.util._ | ||
import java.nio.charset.StandardCharsets | ||
import java.nio.file.{Files, Path} | ||
|
||
class GithubDownload(implicit val system: ActorSystem, implicit val materializer: ActorMaterializer) extends PlayWsDownloader { | ||
class GithubDownload(privateCredentials: Option[GithubCredentials], implicit val system: ActorSystem, implicit val materializer: ActorMaterializer) extends PlayWsDownloader { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
split in two
class GithubDownload(privateCredentials: Option[GithubCredentials])(implicit val system: ActorSystem, implicit val materializer: ActorMaterializer) extends PlayWsDownloader {
Todos:
Sbt config