Fix #122: Add autocomplete bar #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cool the failing test is because of the sbt project rename. I suggest we keep the name server
|
|
Unfortunately, that doesn't work. I tried it out and sbt doesn't respond to the name change. The culprit of this behaviour seems to be the SBT scalajs plugin, which uses a macro to set the project names. |
* Bring back Scalajs! * Add autocompletion and JS dependencies.
|
I've found another way to achieve the same. This PR is ready for review & merge (I have rebased). |
| ) | ||
| ) | ||
|
|
||
| lazy val client = scaladex.js.dependsOn(model) |
There was a problem hiding this comment.
dependsOn(model) I'm not sure this still holds
There was a problem hiding this comment.
That's what you put, so we better leave it.
SBT detects now client and server as independent projects with their own names. Also, when compiling the server for the first time the client is also compiled as a dependency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.