Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore autocomplete/dropdown bar #122

Closed
heathermiller opened this issue Jun 30, 2016 · 2 comments
Closed

Restore autocomplete/dropdown bar #122

heathermiller opened this issue Jun 30, 2016 · 2 comments
Assignees
Milestone

Comments

@heathermiller
Copy link
Contributor

heathermiller commented Jun 30, 2016

No description provided.

@MasseGuillaume
Copy link
Contributor

Hey @jvican!

This is how you get started:
https://github.com/scalacenter/scaladex#how-to-run-scaladex

You will need to install sass
https://github.com/scalacenter/scaladex#requirements

To simplify the build I removed scalajs and the only feature we had using it (dropdown in search). It would like to keep it simple and use plain javascript for the client side.

This was the scalajs code:
72fa081#diff-f7a3ec9b440b60b4b2f3655db460e92dL1

There is some css associated to it:
https://github.com/scalacenter/scaladex/blob/master/server/src/main/assets/partials/_header.scss#L6

This is the api bit you want to use:
https://github.com/scalacenter/scaladex/blob/master/server/src/main/scala/ch.epfl.scala.index.server/Api.scala#L52

This is the place you want to add the GET route:
https://github.com/scalacenter/scaladex/blob/master/server/src/main/scala/ch.epfl.scala.index.server/Server.scala#L218

@jvican
Copy link
Contributor

jvican commented Jul 15, 2016

Hello @MasseGuillaume, thanks!

Just on a side note: I'm really sad we cannot use ScalaJS and that I need to do it with plain javascript.

jvican added a commit that referenced this issue Jul 19, 2016
* Bring back Scalajs!

* Add autocompletion and JS dependencies.
jvican added a commit that referenced this issue Jul 19, 2016
* Bring back Scalajs!

* Add autocompletion and JS dependencies.
MasseGuillaume added a commit that referenced this issue Jul 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants