Remove support for ExplicitResultTypes.skipLocalImplicits option #1209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ExplicitResultTypesConfig uses the Scalameta parser to only compute SemanticDB global symbols and then load those symbols with the presentation compiler. It's not possible to use the same approach for local symbols, so we should drop support for it.
|
Unfortunately @giabao we'll have to revert your PR as this implementation of |
bjaglin
commented
Jul 10, 2020
| g.inverseSemanticdbSymbols(sym.value) | ||
| .find(s => g.semanticdbSymbol(s) == sym.value) | ||
| .getOrElse(g.NoSymbol) | ||
| GlobalProxy.typedTreeAt(g, gpos) |
There was a problem hiding this comment.
@olafurpg is this called just for its side effect ad8a4bb? That goes far beyond my understanding, but when it was added in 162db39#diff-0771fc97e5f15a43af8af2a9e65cbc62R137, there was no explicit side effect so I wonder.
There was a problem hiding this comment.
Correct. This method performs “positioned type checking”, which loads up all the necessary symbols from the classpath. The return value is helpful in other situations like in metals where we use this method to implement parameter hints or completions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1198
Reverts #1181
Rationale: #1198 (comment)