issue 71: reading from java beans #81
Conversation
# Conflicts: # readme/Readme.scalatex
| t.decls.collect { | ||
| case m: MethodSymbol if m.isGetter => | ||
| case m: MethodSymbol if (m.paramLists.isEmpty || m.paramLists == List(List())) && !m.isPrivate => |
There was a problem hiding this comment.
!m.isPrivate should be m.isPublic
There was a problem hiding this comment.
Note that this is also changed in #76 in order for one test to pass. Whichever PR comes first, please keep their behavior (can be factored out to a separate method of course).
| if(config.disableBeanGetterLookup) { | ||
| sourceName == fieldName | ||
| } else { | ||
| sourceName == fieldName || sourceName == s"get$targetNameCapitalized" || sourceName == s"is$targetNameCapitalized" |
There was a problem hiding this comment.
wonder if we should check also source type for isXXX patterns, allowing only Booleans
but not necessarily in this PR
|
Also, please remember about running scalafmt before comitting - otherwise travis build will fail. |
# Conflicts: # chimney/src/main/scala/io/scalaland/chimney/dsl.scala # chimney/src/main/scala/io/scalaland/chimney/internal/DslBlackboxMacros.scala # chimney/src/main/scala/io/scalaland/chimney/internal/MacroUtils.scala # chimney/src/test/scala/io/scalaland/chimney/DslSpec.scala
Codecov Report
@@ Coverage Diff @@
## master #81 +/- ##
==========================================
+ Coverage 92.25% 92.51% +0.26%
==========================================
Files 7 7
Lines 284 294 +10
Branches 62 59 -3
==========================================
+ Hits 262 272 +10
Misses 22 22
Continue to review full report at Codecov.
|
|
Travis build failed due to code being not properly formatted. Please run |
|
Addressed the comments in this PR, but Codacy is now complaining due to too many ifs in |
|
I think you can ignore Codacy - it was complaining for every such if-branch. Instead, I would focus on adding few more test cases to keep the coverage. At least:
|
No description provided.