Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various cleanups #41

Merged
merged 4 commits into from
Jul 3, 2017
Merged

Various cleanups #41

merged 4 commits into from
Jul 3, 2017

Conversation

jonas
Copy link
Collaborator

@jonas jonas commented Jul 3, 2017

olafurpg
olafurpg approved these changes Jul 3, 2017
View reviewed changes
Copy link
Member

@olafurpg olafurpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning this up, very nice. LGTM 👍

metadoc-js/src/main/scala/metadoc/MetadocTextModelService.scala
import monaco.services.ITextEditorModel
import monaco.services.ITextModelResolverService

@ScalaJSDefined
object MetadocTextModelService extends ITextModelResolverService {
// NOTE: we have a private cache here to avoid "duplicate model" errors.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to get rid of this.

metadoc-js/src/main/scala/monaco/MonacoServices.scala
/**
* Service to dynamically load models.
*
* @note This service was renamed to ITextModelService in
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I need to learn scaladoc

jonas added 3 commits July 3, 2017 14:05
@jonas
Move resolveLocation into an XtensionIReadOnlyModel
5dd5738
@jonas
Load the file name from the URL if defined
136a9a5
@jonas
Group model reference requests by file
ebd632c 
Removes the need for the custom model cache and reduces the number of
requests considerably.

References #39
@jonas jonas changed the title Various implements Various cleanups Jul 3, 2017
@jonas jonas merged commit 1ae06c9 into master Jul 3, 2017
@jonas jonas deleted the service-declarations branch July 3, 2017 18:15
@olafurpg olafurpg mentioned this pull request Jul 9, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olafurpg olafurpg olafurpg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonas @olafurpg