Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More efficient reference provider #39

Closed
olafurpg opened this issue Jul 3, 2017 · 1 comment
Closed

More efficient reference provider #39

olafurpg opened this issue Jul 3, 2017 · 1 comment
Labels
bug

Comments

@olafurpg
Copy link
Member

olafurpg commented Jul 3, 2017 •
edited
Loading

The reference provider seems to do a lot of redundant fetches

screen shot 2017-07-03 at 08 43 37

It might be a good idea to change the schema to store a map<string, Ranges> instead of List[(Filename, Range)]. That would mean we only store the filename once for all references in that file and we solve the redundant semanticdb fetching problem.
@olafurpg olafurpg added the bug label Jul 3, 2017
@olafurpg olafurpg changed the title Smarter semanticdb fetching More efficient reference provider Jul 3, 2017
jonas added a commit that referenced this issue Jul 3, 2017
@jonas
Group model reference requests by file
214130f 
Removes the need for the custom model cache and reduces the number of
requests considerably.

References #39
@jonas jonas mentioned this issue Jul 3, 2017
Merged
jonas added a commit that referenced this issue Jul 3, 2017
@jonas
Group model reference requests by file
ebd632c 
Removes the need for the custom model cache and reduces the number of
requests considerably.

References #39
@jonas jonas mentioned this issue Jul 6, 2017
Merged
@olafurpg
Copy link
Member Author

olafurpg commented Jul 9, 2017

I'd say this is fixed in #42, which shrinks the filesize of each symbol file, and #41, which grouped fetches by filename.

@olafurpg olafurpg closed this as completed Jul 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@olafurpg