Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

This updates Metals server version as well as reverts the most recent commit #543

Merged
merged 2 commits into from
Apr 21, 2021
Merged

This updates Metals server version as well as reverts the most recent commit #543

merged 2 commits into from
Apr 21, 2021

Conversation

tgodzik
Copy link
Contributor

@tgodzik tgodzik commented Apr 21, 2021

It seems the languageclient updating is now causing for didFocusDocument notification:

com.google.gson.JsonSyntaxException: java.lang.IllegalStateException: Expected a string but was BEGIN_ARRAY at line 1 column 67 path $.params
	at com.google.gson.Gson.fromJson(Gson.java:944)
	at org.eclipse.lsp4j.jsonrpc.json.adapters.MessageTypeAdapter.fromJson(MessageTypeAdapter.java:329)
	at org.eclipse.lsp4j.jsonrpc.json.adapters.MessageTypeAdapter.parseParams(MessageTypeAdapter.java:249)
	at org.eclipse.lsp4j.jsonrpc.json.adapters.MessageTypeAdapter.read(MessageTypeAdapter.java:119)
	at org.eclipse.lsp4j.jsonrpc.json.adapters.MessageTypeAdapter.read(MessageTypeAdapter.java:55)
	at com.google.gson.Gson.fromJson(Gson.java:932)
	at org.eclipse.lsp4j.jsonrpc.json.MessageJsonHandler.parseMessage(MessageJsonHandler.java:119)
	at org.eclipse.lsp4j.jsonrpc.json.MessageJsonHandler.parseMessage(MessageJsonHandler.java:114)
	at org.eclipse.lsp4j.jsonrpc.json.StreamMessageProducer.handleMessage(StreamMessageProducer.java:193)
	at org.eclipse.lsp4j.jsonrpc.json.StreamMessageProducer.listen(StreamMessageProducer.java:94)
	at org.eclipse.lsp4j.jsonrpc.json.ConcurrentMessageProcessor.run(ConcurrentMessageProcessor.java:113)
	at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
	at java.base/java.lang.Thread.run(Thread.java:834)
Caused by: java.lang.IllegalStateException: Expected a string but was BEGIN_ARRAY at line 1 column 67 path $.params
	at com.google.gson.stream.JsonReader.nextString(JsonReader.java:826)
	at com.google.gson.internal.bind.TypeAdapters$16.read(TypeAdapters.java:402)
	at com.google.gson.internal.bind.TypeAdapters$16.read(TypeAdapters.java:390)
	at com.google.gson.Gson.fromJson(Gson.java:932)
	... 15 more

@tgodzik
Update Metals to 0.10.2
1f09910
@tgodzik
Revert "Update dependencies metals-languageclient to v.0.5.0 and `v…
371dbe5 
…scode-languageclient` to v.7.0.0"

This reverts commit 4d73404.

It seems we are now getting issues with our custom message, so since this is not yet used I will remove it for now.
@tgodzik
Copy link
Contributor Author

tgodzik commented Apr 21, 2021

I will go ahead and merge since this is needed for the release.

@tgodzik tgodzik merged commit 0febe74 into scalameta:main Apr 21, 2021
@tgodzik tgodzik deleted the update2 branch April 21, 2021 16:48
kasiaMarek pushed a commit to kasiaMarek/metals-vscode that referenced this pull request Mar 29, 2023
@mergify
Merge pull request scalameta#543 from scalameta/dependabot/npm_and_ya…
8538318 
…rn/prettier-2.8.4

chore(deps-dev): bump prettier from 2.8.3 to 2.8.4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tgodzik