Metals 0.11.1 Queries & Observations #3535
Replies: 6 comments 18 replies
-
|
Thanks for another portion of feedback @vishalovercome. |
Beta Was this translation helpful? Give feedback.
-
|
I deleted all the generated files and did a fresh build and it works now. There are tickets for some open issues and I'd like to add one more to it - Java tests aren't discovered currently. |
Beta Was this translation helpful? Give feedback.
-
|
Which framework is used in your Java tests? |
Beta Was this translation helpful? Give feedback.
-
|
JUnit 5 |
Beta Was this translation helpful? Give feedback.
-
|
JUnit 5 isn't supported by bloop yet: scalacenter/bloop#996 |
Beta Was this translation helpful? Give feedback.
-
|
I converted this into discussion, since this isn't exactly one issue. Let's try to open issue related to one particular problem that we can fix.
Could you explain a bit more about it? Is it the compialtion taking more time? Maybe it's more memory being used with Java files added and we could increase Xmx? |
Beta Was this translation helpful? Give feedback.
-
|
@Arthurm1 can you shed light on the next steps on Java support? In an another thread you had said that disabling Java support would not be easy. These are the current problems that need to be solved:
|
Beta Was this translation helpful? Give feedback.
-
|
@vishalovercome Thanks for all the feedback. In terms of new functionality - that's undecided. But I'm certainly looking at the various issues that have been raised.
This shouldn't happen - Bloop should happily compile any java code that SBT has compiled. The only thing I can think of is that incremental compilation has an issue with a certain set of changes. Does this happen after issuing a I'd like to know more about your project setup i.e. how many projects Metals lists and do you have scala code that depends on java source or vice versa or mixed. What version of Java are you targeting (seems like JDK 11 from your stacktraces?) Also - how were you using the RedHat Java plugin in combination with Metals before we added java functionality - was it with pure java projects - if not, how were you getting it to compile Scala?
Is this the same as you've written above
This is for Java files or Scala files? I can try and reproduce this but do need to know how you've setup your project files to work with the java plugin. Currently we respond to VScode's |
Beta Was this translation helpful? Give feedback.
-
Are you sure you are on the latest Metals version when testing?
For larger projects it's best to setup
I think Bloop doesn't work well with annotations and code generation, that's true. But again, that would not have worked before
That's an error, if you are able to reproduce it in a smaller setting, please do report it. Overall, it seems that a Java heavy workspace will work better with Intellij, which has a much more mature Java support and I don't think Metals will ever provide. |
Beta Was this translation helpful? Give feedback.
-
Microsoft+RedHat does not work at all with Scala, it's unable to compile it even in a mixed workspace, which is why we wanted to include Java support as part of Metals. We do use the same formatter and scanner. We also tried to include JDT as part of Metals as does the Redhat plugin, but that requires OSGI and is quite complex to set up. The biggest problem here is that there is no actual standard way to interact between servers.
Expression evaluation in Java is not supported, which is why that does not work currently. Intellij is a great tool, which already works well with Java, so as I said previously, it is recommended for Java heavy workspaces. Metals is about Scala + some Java files and we don't aim to be more than that, since this would be incredibly hard to do. |
Beta Was this translation helpful? Give feedback.
-
|
Thanks a lot for such a quick response!
I understand that you can't provide as good a Java support as Scala support. In that case you should offer feature flags for various Java related features. If debugger support cannot be enhanced then I would prefer 0.10.x + Test Explorer + New Scala Features. I can't do that right now as I can't disable new Java support. Definitely flags for disabling code formatting and renaming and other "on the fly" tasks should be considered as they're most likely the reason for drop in performance. If it's not possible then let me know. Many thanks for your support! |
Beta Was this translation helpful? Give feedback.
-
|
I don't think disabling is an option, we try to keep the settings to the minimum. It would be good however to figure out what is causing the preformance degradation for you. Are you able to see what is taking up the bulk of the CPU usage? If it's Bloop then it's a compilation issue, but if it's Metals it might be related to formatting or tokenizing. Would you be able to take a stack trace of the process causing your performance issue? |
Beta Was this translation helpful? Give feedback.
-
|
Just for your info - the formatting only kicks in when you use the VSCode |
Beta Was this translation helpful? Give feedback.
-
|
Would you recommend a JDK other than AdoptOpenJDK? I've read that Zulu JDK results in much better IntelliJ performance but I've never seen any such recommendations in Metals/Bloop doc |
Beta Was this translation helpful? Give feedback.
-
|
No idea, but we've seen some issues with some Zulu versions in Metals, though it might have been an isolated incident. |
Beta Was this translation helpful? Give feedback.
-
|
@vishalovercome I've had a play with using SBT + Lombok + Java + Scala + Metals. Metals seems to handle compilation (in java + scala) and code completion (in scala) ok. A simple Java class... package foo;
import lombok.Data;
@Data
class Foo {
public String bar;
}gets compiled to... class Foo {
public String bar;
public String getBar() {
return this.bar;
}
public void setBar(String string) {
this.bar = string;
}
public boolean equals(Object object) {
if (object == this) {
return true;
}
if (!(object instanceof Foo)) {
return false;
}
Foo foo = (Foo)object;
if (!foo.canEqual(this)) {
return false;
}
String string = this.getBar();
String string2 = foo.getBar();
return !(string == null ? string2 != null : !string.equals(string2));
}
protected boolean canEqual(Object object) {
return object instanceof Foo;
}
public int hashCode() {
int n = 1;
String string = this.getBar();
n = n * 59 + (string == null ? 43 : string.hashCode());
return n;
}
public String toString() {
return "Foo(bar=" + this.getBar() + ")";
}
}and those extra methods can be used in Scala in the same project. This compiles fine... package foo
object BarGetter {
val aFoo = new foo.Foo()
aFoo.getBar()
}You can't navigate to My SBT project is very simple. I'm using Java 17, hence the additional javac options... Could you see if a you could setup a small project that reproduces your issues. Maybe you have some specific build settings that are causing annotation processing issues within bloop. |
Beta Was this translation helpful? Give feedback.
-
|
Does this help - #3562 (reply in thread) ? Reproducing with a smaller project will take me some time - probably I'll get to it this weekend. |
Beta Was this translation helpful? Give feedback.
-
|
I don't use any of the Java options that you have mentioned above. Only bit of Java configuration is:
|
Beta Was this translation helpful? Give feedback.
-
|
FWIW - code navigation works for getters and setters. It always has. |
Beta Was this translation helpful? Give feedback.
-
|
These three lines have 50+ compiler errors according to Metals. Previously I was using just bloop + Metals and this error would come and go away with 0.11.x. It was never a problem with 0.10.x (sbt-eclipse + redhat). Today after Chris's recommendation I switch to sbt and now this error is permanent. Thus my project is now broken as I can't run any launch.json tasks. I will switch back to bloop and continue running sbt for proper compilation and running tests |
Beta Was this translation helpful? Give feedback.
-
|
Are you sure that error comes from sbt though? What does it say for the source ( |
Beta Was this translation helpful? Give feedback.
-
ERROR ERROR StatusLogger Reconfiguration failed: No configuration found for '250b5e5b' at 'null' in 'null'15431 -- main class information unavailablejava.lang.AssertionError: NoDenotation.owneragain #3532 with the new releaseBeta Was this translation helpful? Give feedback.
All reactions