-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Scalameta v4.0 #239
Comments
I am working on getting a scalafix release out this week. |
Currently blocked by scalacenter/scalafix#675 We should be able to go ahead with the upgrade ignoring scalafix related problems. |
(hopefully) Last blocking PR for upgrade scalameta/scalameta#1478 fixing a cross-platform bug that was caught on appveyor. We should really setup a CI on windows |
I'll try to take a stab at this tomorrow, had good success today migrating metadoc scalameta/metabrowse#90 |
The last progress in this is the PR #275. The migration on the Metals side is mostly complete but it the upgrade didn't get merged because it was a regression compared to current master. For example, hover broke after incremental compilation, definition failed for static Java inner classes macro annotation definitions These issues are being addressed in Scalameta v4.0, see the v4.0 milestone to track progress https://github.com/scalameta/scalameta/milestone/26 |
Fixed in #332 |
Currently, Metals is on the latest 2.x release of Scalameta which is from January this year. Since then there have been a ton of improvements in the semanticdb-scalac compiler plugin including
Upgrading will require a decent refactoring of the codebase, which I think we should go ahead with before cutting a v0.1 release.
The text was updated successfully, but these errors were encountered: