Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Scalameta v4.0 #239

Closed
3 tasks
olafurpg opened this issue Apr 4, 2018 · 6 comments
Closed
3 tasks

Upgrade to Scalameta v4.0 #239

olafurpg opened this issue Apr 4, 2018 · 6 comments
Assignees

Comments

@olafurpg
Copy link
Member

olafurpg commented Apr 4, 2018

Currently, Metals is on the latest 2.x release of Scalameta which is from January this year. Since then there have been a ton of improvements in the semanticdb-scalac compiler plugin including

  • more lightweight default settings, it no longer persists info on referenced symbols
  • plenty of bug fixes

Upgrading will require a decent refactoring of the codebase, which I think we should go ahead with before cutting a v0.1 release.

@olafurpg olafurpg added this to the 0.1.0 - Nickel milestone Apr 4, 2018
@gabro gabro mentioned this issue Apr 4, 2018
7 tasks
@olafurpg
Copy link
Member Author

olafurpg commented Apr 4, 2018

I am working on getting a scalafix release out this week.

@olafurpg olafurpg assigned olafurpg and ShaneDelmore and unassigned olafurpg Apr 4, 2018
@olafurpg
Copy link
Member Author

olafurpg commented Apr 5, 2018

Currently blocked by scalacenter/scalafix#675

We should be able to go ahead with the upgrade ignoring scalafix related problems.

@olafurpg
Copy link
Member Author

olafurpg commented Apr 7, 2018

(hopefully) Last blocking PR for upgrade scalameta/scalameta#1478 fixing a cross-platform bug that was caught on appveyor. We should really setup a CI on windows

@olafurpg olafurpg assigned olafurpg and unassigned ShaneDelmore Apr 8, 2018
@olafurpg
Copy link
Member Author

olafurpg commented Apr 8, 2018

I'll try to take a stab at this tomorrow, had good success today migrating metadoc scalameta/metabrowse#90

@olafurpg olafurpg changed the title Upgrade to Scalameta v3.7.0 Upgrade to Scalameta v4.0 once it's ready Jun 29, 2018
@olafurpg
Copy link
Member Author

olafurpg commented Jun 29, 2018

The last progress in this is the PR #275. The migration on the Metals side is mostly complete but it the upgrade didn't get merged because it was a regression compared to current master. For example, hover broke after incremental compilation, definition failed for static Java inner classes macro annotation definitions

These issues are being addressed in Scalameta v4.0, see the v4.0 milestone to track progress https://github.com/scalameta/scalameta/milestone/26

@olafurpg olafurpg changed the title Upgrade to Scalameta v4.0 once it's ready Upgrade to Scalameta v4.0 Sep 28, 2018
@olafurpg olafurpg removed this from the 0.1.0 - Copper milestone Sep 28, 2018
@olafurpg
Copy link
Member Author

Fixed in #332

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants