-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mill's bloopInstall fails due to incorrect call #5387
Comments
Thanks for the report @KaranAhlawat. Just to double check, locally are you using a |
|
The correct module path is mill mill.contrib.bloop.Bloop/install The documentation needs to be corrected! |
What documentation do you mean? https://scalameta.org/metals/docs/build-tools/mill seems to have the correct version. |
The fix hasn't been released yet it seems @KaranAhlawat I will work on a release soon, but in the meantime you can use latest snapshot 0.11.12+161-977d53e3-SNAPSHOT |
Ah, so was the check for the version added after the release of 0.11.12? That would make sense |
Yep, we are late with the release, but I plan to work on that after bumping Bloop to 1.5.7 |
Makes sense to me! I'll be closing the issue then. |
Describe the bug
Upon opening a project a Mill project in VSCode, and then doing Import Build, the bloopInstall command fails. Here is the concerned output
Cannot resolve external module mill.contrib.Bloop
.Expected behavior
Everything works OOTB, without need to run commands from the mill script
Operating system
Linux
Editor/Extension
VS Code
Version of Metals
v0.11.12
Extra context or search terms
The correct command should be using
mill.contrib.bloop.Bloop/install
instead ofmill.contrib.Bloop/install
. Running the same command but with the correct namespace(?) from the terminal produces a .bloop after which Metals works fine.Looking at the code in MillBuildTool.scala, we can see that it should pick the correct command based on the version specified in
.mill-version
file (it can read the version correctly), since 0.11.1 is greater than 0.9.3.However, somehow that ends up being not the case, and the other command is picked. I'm not sure how to debug a running instance of Metals so I'm opening this issue.
Any help is appreciated in advance.
The text was updated successfully, but these errors were encountered: