Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace my UI stuff with Plenary #125

Closed
ckipp01 opened this issue Apr 12, 2021 · 0 comments · Fixed by #229
Closed

Replace my UI stuff with Plenary #125

ckipp01 opened this issue Apr 12, 2021 · 0 comments · Fixed by #229
Labels

Comments

@ckipp01
Copy link
Member

ckipp01 commented Apr 12, 2021

Task

So looking at the docs fornvim_open_win() the config can just take a border argument. There is no title like I currently have, but it might simplify things a lot, which I'm all about. I sort of hate all the stuff I have in ui.lua, and I wouldn't mind literally replacing all of it if I could

Related to this, something else that has been on my mind is that there are certain things in nvim-metals that also part of https://github.com/nvim-lua/plenary.nvim. I think if we are going to start ripping stuff out and replacing it, it may be a good time to really go through everything and see what we could remove via plenary, and then just require plenary as a dependency.

@ckipp01 ckipp01 added the task label Apr 12, 2021
@ckipp01 ckipp01 changed the title Replace my hacky stuff with better stuff Replace my UI stuff with better Plenary May 30, 2021
@ckipp01 ckipp01 changed the title Replace my UI stuff with better Plenary Replace my UI stuff with Plenary Jun 16, 2021
@ckipp01 ckipp01 linked a pull request Oct 1, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
1 participant