-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ability to sort in MetalK8s UI Nodes table #2919
Labels
Comments
alexis-ld
pushed a commit
that referenced
this issue
Nov 13, 2020
Extract Sorting styled components to re-use those in Nodes table Refs: #2919
alexis-ld
pushed a commit
that referenced
this issue
Nov 13, 2020
alexis-ld
pushed a commit
that referenced
this issue
Nov 13, 2020
alexis-ld
pushed a commit
that referenced
this issue
Nov 13, 2020
alexis-ld
pushed a commit
that referenced
this issue
Nov 13, 2020
Move the URL Sync logic for both Volumes and Nodes tables to its custom hook function to avoid a big block of code redundancy. Refs: #2919
alexis-ld
pushed a commit
that referenced
this issue
Nov 13, 2020
Add missing history dependency in useEffect in Sort URL Sync custom hook Refs: #2919
Merged
alexis-ld
pushed a commit
that referenced
this issue
Nov 17, 2020
alexis-ld
pushed a commit
that referenced
this issue
Nov 17, 2020
Version >= 16.9 needed in order to use the custom hook testing library Refs: #2919
alexis-ld
pushed a commit
that referenced
this issue
Nov 17, 2020
Add react-hooks-testing-library to render hooks within a test component Test useTableSortURLSync to check if URL params are handled properly Refs: #2919
ChengYanJin
added a commit
that referenced
this issue
Nov 19, 2020
Autosizer automatically adjusts the width and height of a single child. Refs: #2919
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Component:
'ui'
Why this is needed:
In the same way we can sort in Volumes table, it would be great to have the ability to sort in the Nodes table
What should be done:
Sorting should be available for all columns:
Name: Alphanumeric sorting, case-insensitive (based on Name String only)
Roles: Alphanumeric sorting
Health: Enum sorting: Critical, Warning, Healthy, Unknown
Status: Enum sorting: Ready, NotReady, Unknown
In terms of UI, it should be equivalent to what was done in Volumes table: #2876
Implementation proposal (strongly recommended):
Test plan:
The text was updated successfully, but these errors were encountered: