-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ability to sort list of Volumes in the Volume page #2876
Labels
Comments
alexis-ld
pushed a commit
that referenced
this issue
Oct 28, 2020
Adapt getVolumeListData for table sorting. Removed initial sorting and export latency as a numeric value. Refs: #2876
alexis-ld
pushed a commit
that referenced
this issue
Oct 28, 2020
Implement react-table custom sorting for volume list. Refs: #2876
alexis-ld
pushed a commit
that referenced
this issue
Oct 28, 2020
Set react-table's autoResetSortBy to false to keep sorting active when data refreshes. Refs: #2876
alexis-ld
pushed a commit
that referenced
this issue
Oct 28, 2020
Store volumes sort parameters in URL. Apply sorting if specified in URL. Refs: #2876
alexis-ld
pushed a commit
that referenced
this issue
Oct 28, 2020
Extract health comparison logic to utils file to use it both on initial data sorting and react-table sorting. Refs: #2876
alexis-ld
pushed a commit
that referenced
this issue
Oct 28, 2020
Remove URL param query when sorting resetted back to default. Refs: #2876
alexis-ld
pushed a commit
that referenced
this issue
Oct 28, 2020
Merged
alexis-ld
pushed a commit
that referenced
this issue
Oct 29, 2020
Fix URL loop again by using react-table initial sort with URL queries. Refs: #2876
thomasdanan
added
the
complexity:medium
Something that requires one or few days to fix
label
Nov 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Component:
'ui'
Why this is needed:
In order to ease browsing and focus when looking at Volumes, it would be good to have the ability to sort Volumes per Name, usage, size, Health, Status and latency.
What should be done:
The Volume Page UI should offer the ability to sort on all columns of the table (exclusive sorting: one column at a time). It should be possible to do ascending, descending sort. Because the nature of each info is different between one column or the other, the sorting algo will be different:
Name: Alphanumeric sorting, case-insensitive
usage: Numeric sorting
size: Numeric sorting
Health: Enum sorting: Critical, Warning, Healthy, Unknown
Status: Enum sorting: Link, Unlink and Exclamation
latency: Numeric sorting
By default, the table is sorted by Health (or usage if all Volumes are with the same Health TBC).
In terms of presentation, the user can click on a column to activate the sorting or to change the sorting order. When doing so, the column header is decorated with a little arrow in the right direction, depending on the sort order.
This sorting setting is part of the URL. If it is not part of the URL, the default sorting is applied.
Implementation proposal (strongly recommended):
Test plan:
The text was updated successfully, but these errors were encountered: