Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Salt-master pod (on bootstrap node) not starting if salt-minion failed to start #3022

Closed
thomasdanan opened this issue Jan 11, 2021 · 1 comment
Assignees
Labels
complexity:easy Something that requires less than a day to fix kind:bug Something isn't working priority:medium Medium priority issues, should only be postponed if no other option severity:medium Medium impact (usability) on live deployments topic:operations Operations-related issues

Comments

@thomasdanan
Copy link
Contributor

Component:

'salt', 'bootstrap'

Why this is needed:

If for some reason, salt-minion service failed to start on bootstrap node, the pod salt-master will fail to start with the following error:

Warning FailedMount 4s (x12 over 8m18s) kubelet MountVolume.SetUp failed for volume "run" : hostPath type check failed: /var/run/salt is not a directory [root@zenkotda-bootstrap scality]# systemctl restart kubelet

What should be done:

salt-master pod should be able to start even if salt-minion is not running (i.e. /var/run/salt is not available)

Implementation proposal (strongly recommended):

Test plan:

@thomasdanan thomasdanan added topic:operations Operations-related issues priority:medium Medium priority issues, should only be postponed if no other option severity:medium Medium impact (usability) on live deployments labels Jan 11, 2021
@TeddyAndrieux TeddyAndrieux added the complexity:easy Something that requires less than a day to fix label Jan 14, 2021
@TeddyAndrieux TeddyAndrieux self-assigned this Jan 14, 2021
TeddyAndrieux added a commit that referenced this issue Jan 14, 2021
Salt process create a `/var/run/salt` directory at startup this
directory is shared between salt-master container and salt-minion
running on the host so it's mounted in the container, since this
directory does not exists at system boot we need to use
`DirectoryOrCreate` so that salt-master does not need salt-minion to
start before being able to start

Fixes: #3022
@TeddyAndrieux TeddyAndrieux added the kind:bug Something isn't working label Jan 14, 2021
@NicolasT
Copy link
Contributor

#3041

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
complexity:easy Something that requires less than a day to fix kind:bug Something isn't working priority:medium Medium priority issues, should only be postponed if no other option severity:medium Medium impact (usability) on live deployments topic:operations Operations-related issues
Projects
None yet
Development

No branches or pull requests

3 participants