salt: Create /var/run/salt directory in salt-master manifests

[TeddyAndrieux]

Component:

'salt'

Context:

#3022

Summary:

Salt process create a /var/run/salt directory at startup this
directory is shared between salt-master container and salt-minion
running on the host so it's mounted in the container, since this
directory does not exists at system boot we need to use
DirectoryOrCreate so that salt-master does not need salt-minion to
start before being able to start

---

Fixes: #3022

[bert-e]

Hello teddyandrieux,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

[bert-e]

Waiting for approval

The following approvals are needed before I can proceed with the merge:

• the author

• one peer

Peer approvals must include at least 1 approval from the following list:

• @jbertran

• @ChengYanJin

• @slaperche-scality

• @thomasdanan

• @lucieleonard

• @gdemonet

• @TeddyAndrieux

• @nootal

• @MonPote

• @tcarmet

• @sayf-eddine-scality

• @cmonfort

• @NicolasT

• @carlito-scality

• @alexandre-allard-scality

[gdemonet]

Actually, just checked the DirectoryOrCreate docs:

If nothing exists at the given path, an empty directory will be created there as needed with permission set to 0755, having the same group and ownership with Kubelet

Isn't this going to cause problems? Or we don't care because it's always root:root for both?

[TeddyAndrieux]

Isn't this going to cause problems? Or we don't care because it's always root:root for both?

Today both run as root so we don't really care

[TeddyAndrieux]

/approve

[bert-e]

Build failed

The build for commit did not succeed in branch bugfix/fix-salt-master-start-when-minion-down.

The following options are set: approve

[bert-e]

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

• ✔️ development/2.8

The following branches will NOT be impacted:

• development/1.0
• development/1.1
• development/1.2
• development/1.3
• development/2.0
• development/2.1
• development/2.2
• development/2.3
• development/2.4
• development/2.5
• development/2.6
• development/2.7

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

• Any commit you add on the source branch will trigger a new cycle after the
  current queue is merged.
• Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

[bert-e]

I have successfully merged the changeset of this pull request
into targetted development branches:

• ✔️ development/2.8

The following branches have NOT changed:

• development/1.0
• development/1.1
• development/1.2
• development/1.3
• development/2.0
• development/2.1
• development/2.2
• development/2.3
• development/2.4
• development/2.5
• development/2.6
• development/2.7

Please check the status of the associated issue None.

Goodbye teddyandrieux.