Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ft: ZENKO-781 scale out backbeat services #202

Merged
merged 2 commits into from
Jul 26, 2018

Conversation

jonathan-gramain
Copy link
Contributor

@jonathan-gramain jonathan-gramain commented Jul 20, 2018

  • Modify number of kafka partitions created to nodeCount

  • Set all scalable backbeat components replica count to nodeCount

@jonathan-gramain jonathan-gramain force-pushed the feature/ZENKO-781-scaleOutBackbeatServices branch from 15dd811 to ed302ae Compare July 20, 2018 18:55
@@ -40,10 +40,12 @@ spec:
httpGet:
path: {{ .Values.health.path.liveness}}
port: {{ .Values.health.port }}
initialDelaySeconds: 10
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since most of the backbeat deployments share this value, maybe it should be specified in the values.yaml file. Then it could be templated with something like:

        	livenessProbe:
{{ toYaml .Values.livenessProbe | indent 12 }}
        	readinessProbe:
{{ toYaml .Values.readinessProbe | indent 12 }}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now I keep those changes as an experiment to see how it goes on the CI, but if it helps I'll do this change!

@jonathan-gramain jonathan-gramain force-pushed the feature/ZENKO-781-scaleOutBackbeatServices branch from ed302ae to 571c0bd Compare July 20, 2018 19:24
@@ -40,10 +40,12 @@ spec:
httpGet:
path: {{ .Values.health.path.liveness}}
port: {{ .Values.health.port }}
initialDelaySeconds: 30
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the periodDelay of something like 10-15 would be very useful in this PR as well since the dependency services (kafka and zookeeper) usually take the longest to come up. This way the exponential CrashLoopBackoff doesn't cause the pods to quickly build up a long retry period.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the problem in this PR does not seem related to this initial delay but to conflicts with other pending PRs, let's keep those useful hints aside for a follow-up PR.

@jonathan-gramain jonathan-gramain force-pushed the feature/ZENKO-781-scaleOutBackbeatServices branch from 571c0bd to 84cfb54 Compare July 20, 2018 21:14
@jonathan-gramain
Copy link
Contributor Author

depends on #189 to be merged first, because of the lack of default values for the CI otherwise.

@jonathan-gramain jonathan-gramain force-pushed the feature/ZENKO-781-scaleOutBackbeatServices branch 3 times, most recently from 28a78b8 to bdd9154 Compare July 24, 2018 20:24
@ssalaues ssalaues changed the base branch from master to development/0.9 July 24, 2018 20:39
- Modify number of kafka partitions created to nodeCount

- Set all scalable backbeat components replica count to nodeCount
@jonathan-gramain jonathan-gramain force-pushed the feature/ZENKO-781-scaleOutBackbeatServices branch from bdd9154 to 3806309 Compare July 25, 2018 21:17
@ssalaues ssalaues merged commit 2c4e820 into development/0.9 Jul 26, 2018
@jonathan-gramain jonathan-gramain deleted the feature/ZENKO-781-scaleOutBackbeatServices branch July 26, 2018 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants