-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ft: ZENKO-781 scale out backbeat services #202
ft: ZENKO-781 scale out backbeat services #202
Conversation
15dd811
to
ed302ae
Compare
@@ -40,10 +40,12 @@ spec: | |||
httpGet: | |||
path: {{ .Values.health.path.liveness}} | |||
port: {{ .Values.health.port }} | |||
initialDelaySeconds: 10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since most of the backbeat deployments share this value, maybe it should be specified in the values.yaml
file. Then it could be templated with something like:
livenessProbe:
{{ toYaml .Values.livenessProbe | indent 12 }}
readinessProbe:
{{ toYaml .Values.readinessProbe | indent 12 }}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For now I keep those changes as an experiment to see how it goes on the CI, but if it helps I'll do this change!
ed302ae
to
571c0bd
Compare
@@ -40,10 +40,12 @@ spec: | |||
httpGet: | |||
path: {{ .Values.health.path.liveness}} | |||
port: {{ .Values.health.port }} | |||
initialDelaySeconds: 30 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the periodDelay
of something like 10-15 would be very useful in this PR as well since the dependency services (kafka and zookeeper) usually take the longest to come up. This way the exponential CrashLoopBackoff
doesn't cause the pods to quickly build up a long retry period.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the problem in this PR does not seem related to this initial delay but to conflicts with other pending PRs, let's keep those useful hints aside for a follow-up PR.
571c0bd
to
84cfb54
Compare
depends on #189 to be merged first, because of the lack of default values for the CI otherwise. |
28a78b8
to
bdd9154
Compare
- Modify number of kafka partitions created to nodeCount - Set all scalable backbeat components replica count to nodeCount
bdd9154
to
3806309
Compare
Modify number of kafka partitions created to nodeCount
Set all scalable backbeat components replica count to nodeCount