bf(ZENKO-881): Reduce Azure Test Flakiness #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JianqinWang
approved these changes
Jul 30, 2018
ssalaues
approved these changes
Jul 30, 2018
jonathan-gramain
approved these changes
Jul 30, 2018
| @@ -67,6 +68,7 @@ def delete_blob(self, name): | |||
| def cleanup_azure_bucket(bucket, delete_bucket=True): | |||
| blobs = list(bucket.objects.all()) | |||
| for blob in blobs: | |||
| bucket.delete_blob(blob.name) | |||
| if blob.name.startswith(conf.OBJ_PREFIX): | |||
There was a problem hiding this comment.
Does this account for the bucket_match false addition?
There was a problem hiding this comment.
I.e. is the source bucket name prepended to the key name on the destination?
There was a problem hiding this comment.
At the moment none of the python e2e tests run with bucket_match=false, and I think at this point other changes would have to be made to support it
bennettbuchanan
approved these changes
Jul 30, 2018
|
It may be worthwhile also to add a couple retries to the Azure tests since we seem to be getting |
|
Added the additions proposed by @bennettbuchanan |
add a prefix checking to cleanup_azure_bucket, similar to cleanup_bucket
tmacro
force-pushed
the
bugfix/ZENKO-881_Reduce_Azure_E2E_Flakiness
branch
from
d5a4dcb
to
82b1600
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add a prefix checking to cleanup_azure_bucket, similar to cleanup_bucket