Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bumped kafka-manager version #532

Merged
merged 1 commit into from
Feb 26, 2019
Merged

chore: bumped kafka-manager version #532

merged 1 commit into from
Feb 26, 2019

Conversation

brandonwittwer
Copy link
Contributor

@brandonwittwer brandonwittwer commented Feb 25, 2019

updated patch level from 1.3.3.18 to 1.3.3.22

What does this PR do, and why do we need it?
kafka-manager patch 1.3.3.22 adds kafka 2.x support

Which issue does this PR fix?

fixes #

Special notes for your reviewers:

updated patch level from 1.3.3.18 to 1.3.3.22
@smaffulli
Copy link
Contributor

hi @brandonwittwer ! Thanks for noticing this. Our CI bot is a little unfriendly (we're still training it) and it requires the PR to be formatted in a precise way. We're reaching out to our release engineering team to see if we can merge your PR as-is. Otherwise we may have to close it and one of us will reformat it so that the merging bot won't complain. Stay tuned!

@brandonwittwer
Copy link
Contributor Author

Yeah, I noticed that. looks like the commitlint was happy with this one, but I had deleted one prior. Looks like this is just wanting a review sign-off

@ssalaues ssalaues changed the base branch from development/1.1 to feature/ZENKO-1543-kafka-manager-bump February 26, 2019 18:46
@ssalaues ssalaues merged commit 0b6971f into scality:feature/ZENKO-1543-kafka-manager-bump Feb 26, 2019
@ssalaues
Copy link
Contributor

@brandonwittwer Thanks for the contribution! I retargeted this PR to a trusted branch that our bot and CI will pick up and should get merged into development/1.1 later today here :
#533

@ssalaues
Copy link
Contributor

That's awesome! Glad you could contribute and glad that the docker images are finding good use! 😃

@brandonwittwer
Copy link
Contributor Author

That's awesome! Glad you could contribute and glad that the docker images are finding good use! 😃

Thanks @ssalaues.

I think this was my first approved public github pull request. I'm officially an OSS dev 🥇 (with two keystrokes lol).

I did this for a good reason though. You publish an image to hub.docker.com with the kafka-manager in it and this adds some compatibility updates.

(had to delete other comment, wrong account.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants