Uses appropriate numpy formats for stream values #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
|
Hi @rstdm |
|
I think this can be integrated in xdf-modules/pyxdf#2, so let's continue the discussion there. |
|
Fixed in xdf-modules/pyxdf#2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I noticed that pyxdf returns all numeric samples as numpy.float64 arrays even if the stream’s samples have a different format. This forces me to make needless casts and (in my opinion) is also error-prone.
As fixing this issue shouldn’t break any existing scripts I simply did it myself.
Let me know if you are dissatisfied with my implementation or have any improvement suggestions.