-
Notifications
You must be signed in to change notification settings - Fork 475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some weather descriptions too long for cell width #30
Comments
As you can see, I decided to use truncation.
Any other arguments? |
Simple is usually best. It feels a bit awkward to see the mid-word cut, but I do not have a solution other than expanding the cells, which would suffer from the issues you raised. I'm OK with it as-is, but maybe someone has an elegant solution. |
I could replace the last character with the UTF8 Ellipsis character: „…“? |
I do think that it's more intuitive with a clear indication that it's being truncated. |
Fixed in 66f2ab2 |
As can be seen in the README image, some of the weather descriptions (such as "Patchy rain nearby") are too wide for the column, and are simply cut off when out of space. In this case, should we truncate the text, increase the column width (if we can do so without maximizing terminal width), or expand the column height and use two rows of text?
The text was updated successfully, but these errors were encountered: