Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some weather descriptions too long for cell width #30

Closed
lolstarz opened this issue May 18, 2015 · 5 comments
Closed

Some weather descriptions too long for cell width #30

lolstarz opened this issue May 18, 2015 · 5 comments
Labels

Comments

@lolstarz
Copy link

As can be seen in the README image, some of the weather descriptions (such as "Patchy rain nearby") are too wide for the column, and are simply cut off when out of space. In this case, should we truncate the text, increase the column width (if we can do so without maximizing terminal width), or expand the column height and use two rows of text?

screen shot 2015-05-18 at 5 14 54 pm

@schachmat
Copy link
Owner

As you can see, I decided to use truncation.

  • It is the simplest one to implement
  • Failure or malformed responses cannot clutter up the screen with huge cells
  • The displayed part of the text is enough to grasp the meaning

Any other arguments?

@lolstarz
Copy link
Author

Simple is usually best. It feels a bit awkward to see the mid-word cut, but I do not have a solution other than expanding the cells, which would suffer from the issues you raised. I'm OK with it as-is, but maybe someone has an elegant solution.

@schachmat
Copy link
Owner

I could replace the last character with the UTF8 Ellipsis character: „…“?

@lolstarz
Copy link
Author

I do think that it's more intuitive with a clear indication that it's being truncated.

@schachmat
Copy link
Owner

Fixed in 66f2ab2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants