New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terms with rdfs:labels that do not match term id #1257

Closed
RichardWallis opened this Issue Jul 22, 2016 · 4 comments

Comments

Projects
None yet
3 participants
@RichardWallis
Contributor

RichardWallis commented Jul 22, 2016

Test added for issue (#1256) Identified the following errors that need to be corrected:

INFO:test_graphs:Label matching errors:
INFO:test_graphs:Term 'http://schema.org/' had none-matching label: 'openingHours'
INFO:test_graphs:Term 'http://schema.org/Appearance' had none-matching label: 'Appearance '
INFO:test_graphs:Term 'http://schema.org/ComputerLanguage' had none-matching label: 'ComputerLanguageLanguage'
INFO:test_graphs:Term 'http://schema.org/Dentist' had none-matching label: ' Dentist'
INFO:test_graphs:Term 'http://schema.org/HotelRoom' had none-matching label: 'Hotel Room'
INFO:test_graphs:Term 'http://schema.org/LiveBlogPosting' had none-matching label: 'LiveBlog'
INFO:test_graphs:Term 'http://schema.org/OfflinePermanently' had none-matching label: 'OfflinePermanently '
INFO:test_graphs:Term 'http://schema.org/OfflineTemporarily' had none-matching label: 'OfflineTemporarily '
INFO:test_graphs:Term 'http://schema.org/OnlineFull' had none-matching label: 'OnlineFull '
INFO:test_graphs:Term 'http://schema.org/broadcastTimezone' had none-matching label: 'timezone'
INFO:test_graphs:Term 'http://schema.org/healthPlanCostSharing' had none-matching label: 'offersPrescriptionByMail'
INFO:test_graphs:Term 'http://schema.org/isBasedOn' had none-matching label: 'isBasedOnUrl'
INFO:test_graphs:Term 'http://schema.org/secondaryPrevention' had none-matching label: ' secondaryPrevention'
INFO:test_graphs:Term 'http://schema.org/vehicleIdentificationNumber' had none-matching label: 'vin'
@danbri

This comment has been minimized.

Show comment
Hide comment
@danbri

danbri Jul 22, 2016

Contributor

Thanks! I believe we should continue our practice of the rdfs:label being exactly the same as the last part of the URL. I'll fix these.

Relatedly, @chaals I believe has argued that we should (also) expand out these sometimes cryptic strings into real short sentences, e.g. "is based on". If we do that let's use a different property of the term e.g. alternateName ...

Contributor

danbri commented Jul 22, 2016

Thanks! I believe we should continue our practice of the rdfs:label being exactly the same as the last part of the URL. I'll fix these.

Relatedly, @chaals I believe has argued that we should (also) expand out these sometimes cryptic strings into real short sentences, e.g. "is based on". If we do that let's use a different property of the term e.g. alternateName ...

@RichardWallis

This comment has been minimized.

Show comment
Hide comment
@RichardWallis

RichardWallis Jul 22, 2016

Contributor

I agree - rdfs:label being exactly the same as the last part of the URL gives us a programatic capability for sanity checking that, as in this case, an error has not been introduced.

name or alternateName could be used for extended/multilingual naming.

Contributor

RichardWallis commented Jul 22, 2016

I agree - rdfs:label being exactly the same as the last part of the URL gives us a programatic capability for sanity checking that, as in this case, an error has not been introduced.

name or alternateName could be used for extended/multilingual naming.

@thadguidry

This comment has been minimized.

Show comment
Hide comment
@thadguidry

thadguidry Jul 22, 2016

@danbri Yes Please ! property name expansion with nice parseable strings !

thadguidry commented Jul 22, 2016

@danbri Yes Please ! property name expansion with nice parseable strings !

@danbri danbri closed this in f93cbe8 Jul 28, 2016

danbri added a commit that referenced this issue Jul 28, 2016

@danbri

This comment has been minimized.

Show comment
Hide comment
@danbri

danbri Jul 28, 2016

Contributor

This was a great test, @RichardWallis - wish we'd done it sooner. Fixed a ton of little bugs.

Contributor

danbri commented Jul 28, 2016

This was a great test, @RichardWallis - wish we'd done it sooner. Fixed a ton of little bugs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment