-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VVM: migrate to DEFAS endpoint #400
Comments
Good hint! Fixed via 1105bb2. |
@schildbach I'm really sorry, I think I messed this one up. I confused VVM Mittelschwaben (https://www.vvm-online.de/home) with VVM Mainfranken (https://www.vvm-info.de/) and only looked up the endpoint for the latter. I got the url from the VVM Mainfranken iOS app and did not notice the other VVM app in the App Store. The name of the defas url path did not help. The worst part is that this already happened to me once before.. Unfortunately, while the current app of VVM Mittelschwaben is operated by eos.uptrade, they don't use the efa API. Now the next confusing part is that both providers use https://www.bayern-fahrplan.de in their website for all trip requests [1] [2]. So I guess both providers are connected with DEFAS, which probably also explains why in my testing I didn't even had to update the stop ids. Any idea how to move forward with this? |
Fyi, mobilitaetsverbund.de uses the bayern-fahrplan.de endpoint on their website as well: http://mobilitaetsverbund.de/Fahrplanauskunft,11.html |
So I take it this PR doesn't cause any harm. Am I correct? |
Yes, that's true. Since both providers use DEFAS, there shouldn't be any problems with just switching to VVM Mainfranken which is probably also better known than VVM Mittelschwaben. Even if there is any issue for VVM Mittelschwaben users, they could still fall back to the Bayern provider, which is used on the official website anyways. |
It seems like the currently used endpoint is no longer available. The VVM (iOS) app uses
https://mobile.defas-fgi.de/vvmapp/
, which seems to work just fine and does not use different station ids.The new endpoint uses the mobile efa API. I already implemented the necessary changes in my Swift port of the PTE and changes are very minor (I basically copied all overridden API method from the Bayern provider). If you want, I could submit a PR for PTE as well.
The text was updated successfully, but these errors were encountered: