Replace deprecated setPattern method with setPath. Upgrade minimum sy… #152
Conversation
…mfony to version 2.2 accordingly
|
Was about to do this. Would be nice to get rid of all those deprecation messages in log. |
| "symfony/framework-bundle": "<2.2.12", | ||
| "symfony/css-selector": "<2.2.12", | ||
| "symfony/http-kernel": "<2.2.12", | ||
| "symfony/validator": "<2.2.12", |
There was a problem hiding this comment.
@schmittjoh why having such upper bounds on dev requirements ? It does not make any sense IMO
There was a problem hiding this comment.
The idea was to make sure we are still compatible with the early Symfony versions.
There was a problem hiding this comment.
Support for Symfony 2.1 ended in November 2013. IMHO the min version should be 2.3 that's still supported. I kept 2.2 because the changes were compatible.
There was a problem hiding this comment.
@schmittjoh but this means that you never test with current Symfony versions.
Having a travis job using the lowest deps would be a much more sensible approach
|
+1 for this! I get thousand of warnings per page because of these deprecated methods |
|
+1 for this. I have tons of deprecated messages because of this. Please @schmittjoh, could you please accept this PR and release a new major version? |
|
@schmittjoh what about this PR? |
|
+1 Please accept this. |
|
👍 |
|
👍 |
|
👍 When you plan to release this PR? |
|
👍 |
|
👍 |
|
👍 |
|
+1 |
|
@schmittjoh, any update on this at all? Definitely 👍 from me as well. I'm getting tons of these messages on every page load. Not all of them are due to this bundle but a lot of them are. |
|
👍 |
|
Hi all, I decided to fork the repo and tag a stable release with this patch and #151, feel free to grab it |
|
@acasademont Thanks for doing that! I was planning to do something similar this week and now I don't have to. :) |
|
thanks for this. zikula is now using your fork |
|
@schmittjoh are you still alive? I mean... could you please add another administrator to this repository? |
|
@mmoreram, would you volunteer for that? |
|
@schmittjoh I would love to, but I don't have the time to do it properly. Without this tag I cannot provide Symfony3 compatibility for my project. Thanks. |
|
@acasademont has already published a fork that has merged many of the important fixes. Perhaps he would be willing to take on an expanded role here at the source repo. |
|
@craigh Absolutely. In elcodi we will start using acasademont's fork :) Thanks! |
|
Will be also useful to merge the latest changes by @acasademont to tick off JMSI18nRoutingBundle from here: https://docs.google.com/spreadsheets/d/1GOxJ2lNpLxN12YyZ87Bhsxb0iLAQ7e4UDZbJSly8Sy8/edit#gid=0 |
|
I could do that, no problem :) It's always better to keep the original repo. However, I'm afraid I won't have much time to review new features! BUT we are using this at our company and we'll gladly provide and/or merge patches to always remain compatible with Symfony and fix bugs. |
|
Finally merged ;) |
|
Thank. You. So. Much! 💯 💯 🎉 🎉 |
|
Thanks @acasademont for taking care of this. |
|
thanks! |
|
Thanks! |
…mfony to version 2.2 accordingly